bug#30048: 27.0.50; bibtex-reference-keys is in reverse order

bug#30048: 27.0.50; bibtex-reference-keys is in reverse order

[Basil L. Contovounesios]

The function bibtex-parse-keys in lisp/textmodes/bibtex.el accumulates
BibTeX reference keys in the reverse order of that in which they appear
in the corresponding buffer, before storing them in the variable
bibtex-reference-keys.  AFAICT, there is no utility or need for this
ordering, which can be a nuisance for programs wishing to make in/direct
use of this variable.  See bug#28998 for more concrete justification.

A patch to reverse the accumulated value of bibtex-reference-keys
follows in my next email.

Thanks,

-- 
Basil

In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-01-03 built on thunk
Repository revision: f8b4e87d5d4f57954b50677add76ce5136211dc1
Windowing system distributor 'The X.Org Foundation', version 11.0.11905000
System Description: Debian GNU/Linux testing (buster)

bug#30048: 27.0.50; bibtex-reference-keys is in reverse order

[Basil L. Contovounesios]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-Keep-BibTeX-keys-in-natural-order-bug-30048.patch --]
[-- Type: text/x-diff, Size: 1012 bytes --]

From 109ff5794e29c96b77647837ec3add558143d745 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Tue, 9 Jan 2018 17:20:55 +0000
Subject: [PATCH] Keep BibTeX keys in natural order (bug#30048)

* lisp/textmodes/bibtex.el (bibtex-parse-keys):
Reverse bibtex-reference-keys.
---
 lisp/textmodes/bibtex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index a30e146892..f6cc98241c 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -2932,7 +2932,7 @@ bibtex-parse-keys
               (if verbose
                   (bibtex-progress-message 'done))
               ;; successful operation --> return `bibtex-reference-keys'
-              (setq bibtex-reference-keys ref-keys)))))))
+              (setq bibtex-reference-keys (nreverse ref-keys))))))))
 
 (defun bibtex-parse-strings (&optional add abortable)
   "Set `bibtex-strings' to the string definitions in the whole buffer.
-- 
2.15.1


[-- Attachment #2: Type: text/plain, Size: 62 bytes --]


Kindly find attached the promised patch.

Thanks,

-- 
Basil

bug#30048: 27.0.50; bibtex-reference-keys is in reverse order

[Eli Zaretskii]

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Tue, 09 Jan 2018 18:03:36 +0000
> 
> Kindly find attached the promised patch.

Thanks, pushed to the master branch.