From: Juri Linkov <juri@linkov.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 30280@debbugs.gnu.org, Reuben Thomas <rrt@sc3d.org>
Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore
Date: Wed, 31 Jan 2018 23:44:43 +0200 [thread overview]
Message-ID: <87zi4tu2ic.fsf@mail.linkov.net> (raw)
In-Reply-To: <877erz41re.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 30 Jan 2018 18:53:09 +0000")
> I attach a patch which addresses both bugs. Its solution for (a) is to
> make the advice disposable, i.e. it removes itself from the process
> filter after it has fulfilled its purpose of displaying the output
> buffer. A syntactically simpler implementation of this could use a
> plain boolean switch instead of removing the advice, but IMO the latter
> is semantically more sound (and possibly more performant in subsequent
> invocations of the process filter, though this should be irrelevant).
>
> WDYT?
Thanks, I confirm this is the right thing to do and your patch fixes
the reported issue.
> P.S. Would patch(es) for aesthetic changes to the rest of shell-command
> (such as removing redundant variables, inverting the condition of the
> massive if-then-else to reduce indentation, etc.) be welcome? If so,
> where should I send them?
Such changes are always welcome as patches separate from the actual fixes,
i.e. when not amalgamating bug fixes and code beautification/refactoring
in the same patch.
next prev parent reply other threads:[~2018-01-31 21:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 22:20 bug#30280: async-shell-command-display-buffer doesn't work anymore Juri Linkov
2018-01-29 17:24 ` Eli Zaretskii
2018-01-29 21:40 ` Juri Linkov
2018-01-30 3:24 ` Eli Zaretskii
2018-01-30 18:53 ` Basil L. Contovounesios
2018-01-30 19:06 ` Reuben Thomas
2018-01-31 21:44 ` Juri Linkov [this message]
2018-02-02 10:42 ` Eli Zaretskii
2018-02-03 14:13 ` Basil L. Contovounesios
2018-02-03 21:27 ` Juri Linkov
2018-05-06 16:18 ` Basil L. Contovounesios
2018-05-07 7:35 ` Tino Calancha
2018-05-09 11:54 ` Basil L. Contovounesios
2018-05-09 13:57 ` Tino Calancha
2018-05-09 14:10 ` Noam Postavsky
2018-05-09 14:24 ` Tino Calancha
2018-05-09 18:29 ` Basil L. Contovounesios
2018-05-10 2:13 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi4tu2ic.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=30280@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.