From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Heads-up: Emacs 26.1 RC1 Date: Wed, 21 Mar 2018 17:57:45 +0800 Message-ID: <87zi313g4m.fsf@ericabrahamsen.net> References: <83605snjjt.fsf@gnu.org> <87605raoo9.fsf@killashandra.ballybran.fr> <83zi33n9ud.fsf@gnu.org> <87y3inalb5.fsf@killashandra.ballybran.fr> <83sh8vn7ss.fsf@gnu.org> <87r2of5las.fsf@ericabrahamsen.net> <83d0zzmd3b.fsf@gnu.org> <87muz35f33.fsf@ericabrahamsen.net> <83bmfjm7ew.fsf@gnu.org> <87efke5o3b.fsf@ericabrahamsen.net> <83h8pakkcg.fsf@gnu.org> <878tal4v4b.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521626432 20955 195.159.176.226 (21 Mar 2018 10:00:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Mar 2018 10:00:32 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 21 11:00:28 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyaXj-0005Jr-HQ for ged-emacs-devel@m.gmane.org; Wed, 21 Mar 2018 11:00:27 +0100 Original-Received: from localhost ([::1]:53734 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyaZm-0001YU-QX for ged-emacs-devel@m.gmane.org; Wed, 21 Mar 2018 06:02:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyaZV-0001U4-Bb for emacs-devel@gnu.org; Wed, 21 Mar 2018 06:02:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyaZS-0001Nv-7v for emacs-devel@gnu.org; Wed, 21 Mar 2018 06:02:17 -0400 Original-Received: from [195.159.176.226] (port=58638 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyaZS-0001NU-0v for emacs-devel@gnu.org; Wed, 21 Mar 2018 06:02:14 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eyaXM-0004sN-N4 for emacs-devel@gnu.org; Wed, 21 Mar 2018 11:00:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 48 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:B7+e7VRYeZQr4gvrQRqEue6tGQI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223882 Archived-At: Eric Abrahamsen writes: > Eli Zaretskii writes: > >>> From: Eric Abrahamsen >>> Cc: pierre.techoueyres@free.fr, johnw@gnu.org, emacs-devel@gnu.org >>> Date: Wed, 21 Mar 2018 07:22:48 +0800 >>> >>> > Which code/packages outside of CEDET use the affected functions? >>> >>> Pcache is a big one, as several other packages depend on it -- though I >>> haven't been able to figure out exactly how many from the Melpa repo. It >>> currently errors loudly. The Gnus repository is another, and it is >>> silently corrupted. Those are the main two, and the code changes (though >>> they look large) are specifically targeted at those two packages. A more >>> general solution is in the works for 27, but this was the smallest diff >>> I could manage that fixes the problem. >> >> Then please explain in more detail why the 2nd branch of the 'cond' >> you introduced is needed (the 1st just repeats the original code, so >> it doesn't need any explanation). >> >> Thanks. > > Backing up just a bit, I've made two changes to eieio-persistent over > the past few months, both of them already on 26. Both changes introduced > errors that need to be fixed. They are: > > c59ddb2120 * Fix slot typecheck in eieio-persistent > e1cc2037a9 * Handle hash tables and vectors when reading/writing EIEIO objects > > The first contained a dumb error in that valid types could be returned > as a list, but the code that consumed the return value didn't handle a > list. That mistake is fixed in this (very small) commit on the > fix/eieio-persistent branch: > > 1ea9947ca3 * Handle possible classtype values in eieio-persistent-read > > This fix is necessary to get pcache working again. > > The second commit was also necessary for pcache, as it stores eieio > objects inside hash tables. This wasn't an issue in Emacs 25, because > the hash tables were serialized with `prin1', including their values, > and objects written with `prin1' could be read with `read'. It *is* an > issue in Emacs 26, however, because those objects can no longer be read > with `read'. Commit e1cc2037a9 bf4f34ac7d, sorry...