From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#26750: [PATCH] add missing keywords to js-mode Date: Sat, 28 Apr 2018 17:08:09 -0400 Message-ID: <87zi1nox8m.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1524949634 21778 195.159.176.226 (28 Apr 2018 21:07:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Apr 2018 21:07:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: Jimmy Yuen Ho Wong , 26750@debbugs.gnu.org To: Ruslan Bekenev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 28 23:07:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fCX3k-0005YY-Sd for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Apr 2018 23:07:09 +0200 Original-Received: from localhost ([::1]:53360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fCX5r-0005of-Su for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Apr 2018 17:09:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fCX5f-0005nE-50 for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2018 17:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fCX5a-00083m-5R for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2018 17:09:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34392) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fCX5a-00083X-1b for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2018 17:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fCX5Z-0007vl-Mm for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2018 17:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Apr 2018 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26750 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26750-submit@debbugs.gnu.org id=B26750.152494970730439 (code B ref 26750); Sat, 28 Apr 2018 21:09:01 +0000 Original-Received: (at 26750) by debbugs.gnu.org; 28 Apr 2018 21:08:27 +0000 Original-Received: from localhost ([127.0.0.1]:42289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fCX51-0007uo-IG for submit@debbugs.gnu.org; Sat, 28 Apr 2018 17:08:27 -0400 Original-Received: from mail-it0-f49.google.com ([209.85.214.49]:50244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fCX50-0007uX-JW; Sat, 28 Apr 2018 17:08:26 -0400 Original-Received: by mail-it0-f49.google.com with SMTP id p3-v6so5959049itc.0; Sat, 28 Apr 2018 14:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=1f9I6d4pcJfzZ85xoXeUkVOp8nSba7YU0kdmPX5ir8w=; b=GAXsfhNBacKWQStqCRWPbv9GQGL9t4IpMENUaZkEWZW5b/Aq4ZMpN+AWMXc5+hS1yP A3rMsLGNm4HV4+ANkghHGeyJpgy+wwwB8T8Pqk8GneAY23BU8DzdRLY3f9HlCIsnhdkH f/7poMPUysSoRr4ajYkMC3IgNCkym9MobWmsp3RQM6mkDuq2sp/7LfTR5j3GNWaguqQL 2DJF16pz2Ojm2a3ww/G6sSG5O3u9dutZ33R2EOHikMq6xI4y2GsUdB4nNvwrBhLjVtbb sf69jwdlDkJknlRsIn4nN43kuAgJMesAupX0gHnSDw9GCNnhriSk/6JQsSVyHkoRg6/T FYCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=1f9I6d4pcJfzZ85xoXeUkVOp8nSba7YU0kdmPX5ir8w=; b=ucUTo7jb7vWik3SKbXUcju/5T/uPoalqpLVYf48WVIhOLuqkxDx7Z1k6n++NvU8Ulu 4X81v9JxfhaWC74hx/RF56kOx5HQnCGZPp3Rky3qCVhq0H8Su4IVSQrR7CLrBBTsSquI VFQUDhifv36+xmYTzpfRi63dvHoSwpx65/W15BGRYPP1LXGhcuXd64nnN0LV8f8A9fTu MHXGG+LYto5VLlWIA7DVySyTWEZvs56XnfLetihilKp4l1FmAUWxZ48diCe1WbkNeh0w vs6Ndqa2UQjHUnX1TI4VOqE5znrvl18BtKToNDqQKWQONlmYo9iM5lt6KVvSvynAeA5A 1XIw== X-Gm-Message-State: ALQs6tBPq8B12GapDLD6w5lyxUZ5CYT6xmNFSzgwatl7EInERHkkjhZT 8RDnFlG3Ua6/H8J45ggvkIccTA== X-Google-Smtp-Source: AB8JxZofM/xR63U03vK5z9DXR6OZlqo7KIthd31Bg0wDeYwwFnbPHL1rL545n4uaSegGY3XOL9glNw== X-Received: by 2002:a24:1995:: with SMTP id b143-v6mr59628itb.84.1524949700851; Sat, 28 Apr 2018 14:08:20 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q67-v6sm1986522ita.11.2018.04.28.14.08.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Apr 2018 14:08:20 -0700 (PDT) In-Reply-To: (Ruslan Bekenev's message of "Fri, 12 May 2017 14:12:32 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145813 Archived-At: forcemerge 26750 31306 quit Ruslan Bekenev writes: > Hi. It is my first contribution.=C2=A0 > I hope everything is correct with this PATCH and submission itself.=C2=A0 > In this patch added two missed keywords to `js--keyword-re` which are `as= ` and `of`.=C2=A0 > `async` and `await` are already there.=C2=A0 Hi, sorry your patch was overlooked for so long. Unfortunately, I think just adding keywords to js--keyword-re will not quite do the right thing, based on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31306#5: Specially, "as" and "from" should only be highlighted in an import statement. "of" should only be highlighted in a for statement. Any other occurrances of "as", "from" and "of" should not be highlighted as they are legal identifiers outside of import and for statements respectively.