all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: string-to-unibyte in image-jpeg-p
Date: Thu, 24 May 2018 17:31:40 +0200	[thread overview]
Message-ID: <87zi0prrxf.fsf@gmail.com> (raw)
In-Reply-To: <83tvqxaxof.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 24 May 2018 18:19:28 +0300")

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> Maybe so, but I prefer Paul's way.  We should be very careful not to
> remove features hastily, without due heads-up to possible users.

Ok for master?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Obsolete-image-jpeg-p.patch --]
[-- Type: text/x-diff, Size: 692 bytes --]

From 5b7f50a8a7358b39119fecd8706f5c1713421379 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Thu, 24 May 2018 17:28:11 +0200
Subject: [PATCH] Obsolete image-jpeg-p
To: emacs-devel@gnu.org

* lisp/image.el (image-jpeg-p): Declare obsolete.
---
 lisp/image.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/image.el b/lisp/image.el
index e084fe329a..95acda0b07 100644
--- a/lisp/image.el
+++ b/lisp/image.el
@@ -270,6 +270,8 @@ image-jpeg-p
 				     (substring data i (min (+ i nbytes) len)))))
 	    (setq i (+ i 1 nbytes))))))))
 
+(make-obsolete 'image-jpeg-p nil "27.1")
+
 
 ;;;###autoload
 (defun image-type-from-data (data)
-- 
2.17.0.775.ge144d126d7


  reply	other threads:[~2018-05-24 15:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 10:21 string-to-unibyte in image-jpeg-p Thien-Thi Nguyen
2018-05-23 19:43 ` Stefan Monnier
2018-05-23 20:01 ` Eli Zaretskii
2018-05-23 20:17 ` Andreas Schwab
2018-05-23 20:29   ` Stefan Monnier
2018-05-23 20:46     ` Paul Eggert
2018-05-24  8:51       ` Robert Pluim
2018-05-24 15:19         ` Eli Zaretskii
2018-05-24 15:31           ` Robert Pluim [this message]
2018-05-24 17:09             ` Eli Zaretskii
2018-05-24 19:51             ` Stefan Monnier
2018-05-25  6:10               ` Eli Zaretskii
2018-05-25 18:01                 ` Stefan Monnier
2018-05-25 19:13                   ` Eli Zaretskii
2018-05-25 20:39                     ` Stefan Monnier
2018-05-26  8:27                       ` Eli Zaretskii
2018-05-31 10:40               ` Robert Pluim
2018-05-31 14:50                 ` Eli Zaretskii
2018-05-31 15:17                   ` Robert Pluim
2018-05-24 15:59           ` Stefan Monnier
2018-05-24 17:00             ` Eli Zaretskii
2018-05-24 19:51               ` Stefan Monnier
2018-05-25  6:10                 ` Eli Zaretskii
2018-05-26 21:02                   ` Stefan Monnier
2018-05-24 16:57           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi0prrxf.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.