From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: pcase: Semantics of atom QPATS Date: Sat, 16 Jun 2018 09:32:10 +0200 Message-ID: <87zhzvtced.fsf@web.de> References: <87tvqbjwyf.fsf@web.de> <87k1r3qro3.fsf@web.de> <87vaaj9y4b.fsf@web.de> <83d0wr1ami.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529134230 16959 195.159.176.226 (16 Jun 2018 07:30:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 07:30:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 16 09:30:25 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fU5fF-0004KP-GT for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 09:30:25 +0200 Original-Received: from localhost ([::1]:50527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU5hM-00045v-8g for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 03:32:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU5hD-00045e-R2 for emacs-devel@gnu.org; Sat, 16 Jun 2018 03:32:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fU5hD-0006Uy-0T for emacs-devel@gnu.org; Sat, 16 Jun 2018 03:32:27 -0400 Original-Received: from mout.web.de ([212.227.15.4]:43133) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fU5h7-00067B-KO; Sat, 16 Jun 2018 03:32:21 -0400 Original-Received: from drachen.dragon ([188.110.196.170]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lu1Be-1gBQpk1QZC-011UiM; Sat, 16 Jun 2018 09:32:14 +0200 In-Reply-To: <83d0wr1ami.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Jun 2018 09:57:57 +0300") X-Provags-ID: V03:K1:hpbhO+4IvTED7MgPzll8XGMuJZ3GI7tOO38cdGruY4pQ7zs4i1J bHuPWJW7Tvyusz7wuh67DuNVGFM9G6p5zeoR1jmu7z8FRZ4WKDlUvtbaPErmcdlWhAWB6se vG8w4lsx+XXUkYT447hQOtpOclLn1afRJGQrbyoBTPegbvfXEpZOICUON7bfT/LjZN+4HiU 3n7mi+YRTU/Nztnkgay+w== X-UI-Out-Filterresults: notjunk:1;V01:K0:MoEDykIaCaw=:FazfAC9qcbVGaGtySK++De 3MHi/WWwV4BCvw87N220Wo5vv/OFytpX8+5Gqp3K6bsYDOZ2pkzwvS7vyRjPQnF7Gh2FWqZEZ IdtnkJvPDGKnxKPD8mxRM2p6qM59sI5fhrRVmIyJ70CmAxSIwrkaIiO4TxVCRVoG+httnTGWn 69eZAGmAjD14h8e9MubKKZwuUwaEkcYReWeDxP2AERaHimZwAePLA6lOovwdrftszo4HJOZGC oO15bc3hjttDNR3bKCmzg0/1QFyCjeL61SDseEf+pR/PcU9/RmLeDrpgnSbWvv37+3IayWgdf WieHhDzcuQnZ6jM/2L70bULoDQQZfYiCZDUFaYhNYcShHmbNpbJSNvn+XmHrYeiEyxec/lJ4z shyUlM6Oqv+Q95amXlW9kPP8aAYwo0psBPkzjGVsBIbHhTtLsvalqVgPUGQGBMQQO6QsubwWg rI7ZfwkG67cIKFOOEHt8ngai58PM3mB117Btz/mByp0ODs6isGV7xPS7PV4WRAYICohLTv84Q dlpovw9A1iIwy3wQ0z5cH0lj+P182tqr45ZVLB/OXKDbsqQphkUBmY2Wl8YfKkVaa+9uoYEXs kwr6HLfSvbKwBD0oM7nKTrKITA3vx0lNcU7Ex7Curj44BEX+E3zGY0XrGA/TJGchVbE172uiW sK4ag+uoJ2GcuwjIdz42mqXpFF2kBH+LVKVFay3Ri4U5/h5exQD2H6cHDEn5tDf5AddwlNdEP U97IrxzL5BrAyDW4f+jS1BQAOjBbC5AhUVoRfJS+B4D7uPeU+K3Jv0OMclTQgNhQB8vBY7P9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226349 Archived-At: Eli Zaretskii writes: > > Ok. Is this patch ok for emacs-26? > > Changes in documentation and comments are always okay there, but I'm > uneasy with changes that modify behavior. Why is it important to > support non-integer numbers in Emacs 26.2? It's not important, no I thought it would be harmless, but master is ok for me. > > - ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat) > > + ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat) > > Any reasons to use numberp and not number-or-marker-p? Is it likely that someone constructs a pcase pattern with a literal marker in it? Note this is about the pattern, not about the matched value. Michael.