Re: pcase: Semantics of atom QPATS

[Michael Heerdegen <michael_heerdegen@web.de>]

Eli Zaretskii <eliz@gnu.org> writes:

> > Ok.  Is this patch ok for emacs-26?
>
> Changes in documentation and comments are always okay there, but I'm
> uneasy with changes that modify behavior.  Why is it important to
> support non-integer numbers in Emacs 26.2?

It's not important, no I thought it would be harmless, but master is ok
for me.

> > -   ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat)
> > +   ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat)
>
> Any reasons to use numberp and not number-or-marker-p?

Is it likely that someone constructs a pcase pattern with a literal
marker in it?  Note this is about the pattern, not about the matched
value.


Michael.