From: Noam Postavsky <npostavs@gmail.com>
To: Jonathan Kyle Mitchell <kyle@jonathanmitchell.org>
Cc: 30724@debbugs.gnu.org, Yegor Timoshenko <yegortimoshenko@riseup.net>
Subject: bug#30724: eshell: escaped tilde is not treated as such
Date: Sat, 07 Jul 2018 15:17:30 -0400 [thread overview]
Message-ID: <87zhz2dfed.fsf@gmail.com> (raw)
In-Reply-To: <97031714eb3479b466bca0545b76114e4d40e898.camel@jonathanmitchell.org> (Jonathan Kyle Mitchell's message of "Fri, 06 Jul 2018 02:24:20 -0500")
Jonathan Kyle Mitchell <kyle@jonathanmitchell.org> writes:
> tags 30724 + patch
> quit
You have to send this control@debbugs.gnu.org to have effect, generally
you should use Bcc so that further replies don't go there (which is why
you don't see it when other people do this).
> I found a way to get eshell to escape special chars. It seems most of
> the eshell builtin commands that take file arguments are already tagged
> with the eshell-no-numeric-conversions property. By adding the true
> part of the if condition in eshell-lisp-command, it is possible to
> quote the arguments of special filenames. The attached patch checks
> for "~" and "*".
Perhaps we should distinguish between file and non-numeric arguments
though? E.g., I think the file-name-quote might not make sense for the
commands below:
> ./esh-proc.el\0202:(put 'eshell/kill 'eshell-no-numeric-conversions t)
> ./em-unix.el\0167:(put 'eshell/man 'eshell-no-numeric-conversions t)
> ./em-unix.el\0664:(put 'eshell/make 'eshell-no-numeric-conversions t)
> ./em-unix.el\01050:(put 'eshell/locate 'eshell-no-numeric-conversions
> ./em-unix.el\01059:(put 'eshell/occur 'eshell-no-numeric-conversions t)
> ./esh-cmd.el\01185:(put 'eshell/which 'eshell-no-numeric-conversions t)
> ./em-tramp.el\097:(put 'eshell/su 'eshell-no-numeric-conversions t)
> ./em-tramp.el\0139:(put 'eshell/sudo 'eshell-no-numeric-conversions t)
> Fix bug#30724 by checking if "*" and "~" are arguments to the current command
> and quoting them relative to `default-directory' if so. This leverages the
> the fact that the existing eshell builtin commands that accept file arguments
> are tagged with the eshell-no-numeric-conversions property. The existing
> details of eshell command execution are left unchanged.
>
> * lisp/eshell/esh-cmd.el (eshell-lisp-command)
The ChangeLog item should at the beginning, as in,
* lisp/eshell/esh-cmd.el (eshell-lisp-command): Fix bug#30724 by
checking if "*" and "~" are arguments to the current command ...
next prev parent reply other threads:[~2018-07-07 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 4:30 bug#30724: eshell: escaped tilde is not treated as such Yegor Timoshenko
2018-03-09 1:15 ` Noam Postavsky
2018-07-06 7:24 ` Jonathan Kyle Mitchell
2018-07-07 19:17 ` Noam Postavsky [this message]
2018-07-15 17:18 ` Jonathan Kyle Mitchell
2018-07-17 0:14 ` Noam Postavsky
2018-07-18 3:54 ` Jonathan Kyle Mitchell
2018-07-22 1:34 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhz2dfed.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=30724@debbugs.gnu.org \
--cc=kyle@jonathanmitchell.org \
--cc=yegortimoshenko@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.