From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Wed, 08 Aug 2018 17:37:27 -0600 Message-ID: <87zhxwig5k.fsf@tromey.com> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> <87ftzrknyg.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533771343 21340 195.159.176.226 (8 Aug 2018 23:35:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2018 23:35:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 09 01:35:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnXzO-0005RD-EE for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 01:35:38 +0200 Original-Received: from localhost ([::1]:45903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnY1T-000349-Au for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2018 19:37:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnY1H-000344-5C for emacs-devel@gnu.org; Wed, 08 Aug 2018 19:37:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnY1C-0003GE-7u for emacs-devel@gnu.org; Wed, 08 Aug 2018 19:37:35 -0400 Original-Received: from gateway34.websitewelcome.com ([192.185.148.142]:36965) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnY1C-0003Fc-1V for emacs-devel@gnu.org; Wed, 08 Aug 2018 19:37:30 -0400 Original-Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id B5FFC2DB357 for ; Wed, 8 Aug 2018 18:37:28 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nY1AfLgr8kBj6nY1AfdPdX; Wed, 08 Aug 2018 18:37:28 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=b5OPKlRnBluzVLwZ5MM0Nmxs4zNCNN8Xzg+F//WOJN0=; b=rKOF/HEoKs1DKi9ir/PrYYZakg Owut9uWKPBCt0WsYkcdSZ0S4VOittNBvL3x06qPWZL1BZeC6dILfiGQiusdJ625q9MPEt7zqsrCk5 Z+E/xax5GU3LnKJMuR10lOCRk; Original-Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:34944 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnY1A-0027JF-BS; Wed, 08 Aug 2018 18:37:28 -0500 X-Attribution: Tom In-Reply-To: (Andy Moreton's message of "Wed, 08 Aug 2018 17:35:31 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1fnY1A-0027JF-BS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (bapiya) [75.166.85.72]:34944 X-Source-Auth: tom+tromey.com X-Email-Count: 18 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.148.142 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228317 Archived-At: >>>>> "Andy" == Andy Moreton writes: Andy> Have you run "make check" on the bignum branch ? I did this and fixed the problems I saw. Andy> 1) A crash in the json tests Andy> This is bug#32381, fixed on master in commit 3eac378c96. I didn't see this, but since it is unrelated to the branch, I wouldn't have anyway. I just ran "make check" at the top level. Is there something else I should do? Andy> 2) An eassert in make_bignum_str called from string_to_number. Andy> This appears to be caused by differences in the syntax accepted by Andy> emacs lisp and by mpz_set_str. To reproduce: ELISP> (format "+%S" (- most-negative-fixnum)) Andy> "+2305843009213693952" ELISP> (string-to-number "+2305843009213693952") Andy> ### crash ### I fixed this. Andy> 3) Another crash which I have not yet had time to analyse with gdb. I didn't see this. However, emacs-module-tests.el had a test failure; I've updated the test. I've pushed all the patches I have. Tom