From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Raimon Grau Newsgroups: gmane.emacs.bugs Subject: bug#32372: [PATCH] Add "uuid" to thing-at-point.el Date: Thu, 09 Aug 2018 19:50:07 +0100 Message-ID: <87zhxvwf1c.fsf@konghq.com> References: <87h8k88l47.fsf@konghq.com> <87effc8kj1.fsf@konghq.com> <8736vsz0mo.fsf@gmail.com> <878t5j9674.fsf@konghq.com> <87mutzxq3k.fsf@gmail.com> <87600m8vn9.fsf@konghq.com> <87600m48pq.fsf@violet.siamics.net> <8736vny1c8.fsf@konghq.com> <87bmab2yu1.fsf@violet.siamics.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1533840612 860 195.159.176.226 (9 Aug 2018 18:50:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2018 18:50:12 +0000 (UTC) Cc: Noam Postavsky To: Ivan Shmakov , 32372@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 09 20:50:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnq0d-0008UR-M6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Aug 2018 20:50:07 +0200 Original-Received: from localhost ([::1]:52407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnq2i-0004dy-Mg for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Aug 2018 14:52:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnq2Y-0004dD-AG for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 14:52:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnq2U-000147-Ck for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 14:52:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnq2U-00013w-3k for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 14:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fnq2T-0005Zw-N3 for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 14:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Raimon Grau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Aug 2018 18:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32372-submit@debbugs.gnu.org id=B32372.153384071521432 (code B ref 32372); Thu, 09 Aug 2018 18:52:01 +0000 Original-Received: (at 32372) by debbugs.gnu.org; 9 Aug 2018 18:51:55 +0000 Original-Received: from localhost ([127.0.0.1]:46147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnq2K-0005ZX-SG for submit@debbugs.gnu.org; Thu, 09 Aug 2018 14:51:54 -0400 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:36706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnq2J-0005ZH-AM for 32372@debbugs.gnu.org; Thu, 09 Aug 2018 14:51:51 -0400 Original-Received: by mail-wr1-f41.google.com with SMTP id h9-v6so6041247wro.3 for <32372@debbugs.gnu.org>; Thu, 09 Aug 2018 11:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konghq.com; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=La67Y6/dnY6Ol+cKgsNUd2rjIX+Z2Jl5CXCY4wVgIOM=; b=TQmAyX4PKOubnwHLmY3eWrl9IHvI50LF/oEC37ylH9RLoDxESJ0R2BJKmipP4/k6Ii d7Noo0RJSRBcn6UwotmX5zq44xWamvKsZMGdbnuQ1eZE//tgaVjE+6fRmSzylMUNjlgc OZmiYDK/zDg5hp+WY5qF28mrD866AvetupaL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=La67Y6/dnY6Ol+cKgsNUd2rjIX+Z2Jl5CXCY4wVgIOM=; b=qh9GwueMukiFCCwVVPtDM1C0r8zgiU/UiU4NSUIPp6Hg7sYDSno8u2CidRLWRddNFo ANU/qet2Jpx2Eq0o9NLLmFaFLQ5jsTMdJAP7Kt+FAq088ixyadp1BBwHUubRzhEVwJFj dwWor1H8Z+cNZ9C8hUOu7t7UbRgZY/ldjMeh0PGceUJdXYpC64hUU7tjbb379EXnraCA Z76bS36kOeJt461MtlqTkzwFFvK3tdZ7DhzunkzrULHLy79oE1vfq3rleK78/ABExnUk ov4GYhKH0w+XQFFs0d2ZuO1dxge6bBwzlHJQQD62deD11yccGKrDVfvP6RxPVPPM0COu 7j4w== X-Gm-Message-State: AOUpUlEB2HIny2WRPv28GcKSjePgt1wBpRXD9YEGVxotfR01Rbg8oyEB /cMV44h2R948Ag6+CkSUdsE4Vw== X-Google-Smtp-Source: AA+uWPywPWDYcVNQb8Ehqy/7zY8GGFG0Tmrx5Woo/PMV7MAUkaOsGjLSyDfqxXAGxwRNLUgH8k4wlg== X-Received: by 2002:adf:b188:: with SMTP id q8-v6mr2146440wra.95.1533840705547; Thu, 09 Aug 2018 11:51:45 -0700 (PDT) Original-Received: from raikong (55.19.183.185.dyn.akiwifi.com. [185.183.19.55]) by smtp.gmail.com with ESMTPSA id 31-v6sm15198347wra.26.2018.08.09.11.51.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 11:51:44 -0700 (PDT) X-Google-Original-From: Raimon Grau In-Reply-To: <87bmab2yu1.fsf@violet.siamics.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149392 Archived-At: Ivan Shmakov writes: > While either =E2=80=98and=E2=80=99 or =E2=80=98if=E2=80=99 can be used h= ere, to exactly the same > effect, the indentation above is one for =E2=80=98if=E2=80=99; =E2=80=98= and=E2=80=99 should instead > look like: > > (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36) > (cons (match-beginning 0) (match-end 0))) > > I think in this case it=E2=80=99s marginally better to keep indentation > and replace =E2=80=98and=E2=80=99 with =E2=80=98if=E2=80=99 than the oth= er way around. What about `when'? Is it ok to use it? One branch 'if' look funny to me but I don't see many (any?) `when' in the = emacs codebase. Thanks, Raimon Grau