Re: [PATCH] open bookmark in other frame

[Karl Fogel <kfogel@red-bean.com>]

Drew Adams <drew.adams@oracle.com> writes:
>My suggestions in this regard, FWIW:
>
>1. Don't use `view-buffer-other-frame'.
>    Select the buffer, and not just read-only. Jumping to a bookmark
>    typically puts you at its location (hence select), and the buffer is
>    typically not put in a read-only mode. IOW, do the equivalent of
>    this, or similar:
>
>    (let ((pop-up-frames  t)) (bookmark-jump-other-window bookmark)

Agreed -- there's no reason it should be read-only.  Jumping to a bookmark doesn't normally cause the destination to be read-only, so there's no reason that should happen just because we're in a new frame.

(I haven't studied `pop-up-frames' enough to know whether Drew's back-of-the-envelope solution above is the best way, but presumably a little more research would lead to the best way.)

>2. Don't use `F' as the key binding in the bookmark-list buffer.
>    `F' is more often used for files than for frames. Maybe use `5'.
> 
>    (I use `J 5' in Bookmark+. `J' is a prefix for the jump commands
>    in the bookmark-list buffer. The `5' is from `C-x 5' bindings for
>    other-frame. I bind the command to `C-x 5 B' and `C-x j 5' globally.
>    `C-x j' is a global prefix key for bookmark jump commands.)

I don't have a strong opinion here, but my fingers also lean slightly toward "5" because of `C-x 5 b', for what it's worth.

Thanks for noticing that `view-buffer-other-frame' leads to read-onlyness, Drew, and for the "5" idea.

Best regards,
-Karl