From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#33145: 27.0.50; rcirc race receives duplicate messages Date: Thu, 25 Oct 2018 04:02:35 +0100 Message-ID: <87zhv2g244.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540436467 30757 195.159.176.226 (25 Oct 2018 03:01:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 25 Oct 2018 03:01:07 +0000 (UTC) To: 33145@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 25 05:01:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFVtN-0007sN-Gs for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Oct 2018 05:01:01 +0200 Original-Received: from localhost ([::1]:52110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFVvU-0000Zw-63 for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2018 23:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFVvN-0000Zd-S4 for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 23:03:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFVvL-0005Mc-4h for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 23:03:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36841) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gFVvL-0005MO-0T for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 23:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gFVvK-0002Eo-Q1 for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 23:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Oct 2018 03:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33145 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15404365758584 (code B ref -1); Thu, 25 Oct 2018 03:03:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Oct 2018 03:02:55 +0000 Original-Received: from localhost ([127.0.0.1]:41099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFVvD-0002EN-79 for submit@debbugs.gnu.org; Wed, 24 Oct 2018 23:02:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFVvB-0002EA-VU for submit@debbugs.gnu.org; Wed, 24 Oct 2018 23:02:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFVv6-00058L-1Y for submit@debbugs.gnu.org; Wed, 24 Oct 2018 23:02:48 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:48622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gFVv5-00058C-UE for submit@debbugs.gnu.org; Wed, 24 Oct 2018 23:02:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFVv5-00006h-2l for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 23:02:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFVv2-00053t-Ct for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 23:02:46 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:42276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gFVv2-0004zf-4d for bug-gnu-emacs@gnu.org; Wed, 24 Oct 2018 23:02:44 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id b7-v6so6982105edd.9 for ; Wed, 24 Oct 2018 20:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=9uapVX/my9R+yQNG7Vwg8epHmeV0Zbe0se7aXUrOfH4=; b=c1sKtVwGEBT0/dTWXYB+xAyszc9PvMYMk5aqVBnn+P7SdP0TbKYCtjKAv9LHuv8Po3 /MqXWUV80n2CtkoeWKkV9ZdxG4XPFdQvHVz/U2v/OzqsidW1tNi+BY24VTWKYJTp6QTs X7X4j8Tsrfd4UDIFtZoiTugHKI44lenMOhmDT2ox+I3p6VKu4xJEUKcrbasRNWxagLmq uZDyu5zF2zqEvLBBJm7hcUTuyvplXXTQ8KyoY9cI7tm3OQVjKAiQZJ6GyvSlngrojc+e 3E15gCx8etimj1OoAJbgyT/Z/8KFJDqQYuD561WvrTgKl1gx6c1NO0cNZcZJ9SQT6d/2 4aOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=9uapVX/my9R+yQNG7Vwg8epHmeV0Zbe0se7aXUrOfH4=; b=DsLk+VVlFrN8bKfmsQIPZPK3VVzzRTUBevMsc0SrAN6XpQhY/QPcVxOW2PBhZ/DfT8 SJMkGFQ3r7rKPopluJ0N7X57ljTTxKElmYEoaEt/no9K5ug9cH2terNxO0JHLIE8uNDk jBD88Mrrns17RQZ5ZZRlAGHFzVvZ4zedQxjaXNe3udBGlTuXkEfypN+Ir01FDPMp2oKv 1d4ZhqwhqWZVk6q3UEhpMPqT5j6qabfHePl8A/6RKfds/v+7JHz2m84an/BlAoEF7CUZ j2VdNHw+DOvdEBbvGUw348m4zx9tSYH7XTJTCID+MoT+r156KRotzTlElGniZs5wSVaE xA4Q== X-Gm-Message-State: AGRZ1gK1nYisCW7EWM1Afrp7BIENpHCLDK2QR5QXqx8R91T093EA6/f/ AaxxCa5XS0L/CKub4dMtjWg9Wkbwic8= X-Google-Smtp-Source: AJdET5dmmo2LdmTin1xajVWIEAYMZjMalZvnroiRMXoJRMcvJ7NyOIdhoD6h3e4OWSzB4Y9u/fnxkA== X-Received: by 2002:a50:9226:: with SMTP id i35-v6mr128569eda.50.1540436562136; Wed, 24 Oct 2018 20:02:42 -0700 (PDT) Original-Received: from localhost (51-171-243-2-dynamic.agg2.clk.blp-srl.eircom.net. [51.171.243.2]) by smtp.gmail.com with ESMTPSA id l52-v6sm2491163edc.10.2018.10.24.20.02.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Oct 2018 20:02:41 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151582 Archived-At: Currently, rcirc-filter clears the accumulator variable rcirc-process-output only after each of its constituent lines has been fed to rcirc-process-server-response, which in turn runs the abnormal hook rcirc-receive-message-functions. If this hook contains a function which allows process filters to be run, e.g. by way of accept-process-output, and if process output arrives soon enough, then rcirc-filter might be called more than once before its previous invocation has managed to clear rcirc-process-output. In other words, subsequent invocations may see process output that is already being handled by previous invocations, thus potentially printing duplicate messages in the process buffer. Patch addressing this to follow. Thanks, -- Basil In GNU Emacs 27.0.50 (build 31, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2018-10-24 built on thunk Repository revision: 00027ff9d0f646662458bdb47cc7e2214f439698 Windowing system distributor 'The X.Org Foundation', version 11.0.12001000 System Description: Debian GNU/Linux buster/sid Configured using: 'configure --config-cache --prefix=/home/blc/.local --with-mailutils --with-x-toolkit=lucid --with-modules --with-file-notification=yes --with-x 'CC=ccache gcc' 'CFLAGS=-O2 -march=native -pipe'' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON LCMS2 GMP