all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: 33145@debbugs.gnu.org
Subject: bug#33145: 27.0.50; rcirc race receives duplicate messages
Date: Thu, 25 Oct 2018 04:02:35 +0100	[thread overview]
Message-ID: <87zhv2g244.fsf@tcd.ie> (raw)

Currently, rcirc-filter clears the accumulator variable
rcirc-process-output only after each of its constituent lines has been
fed to rcirc-process-server-response, which in turn runs the abnormal
hook rcirc-receive-message-functions.

If this hook contains a function which allows process filters to be run,
e.g. by way of accept-process-output, and if process output arrives soon
enough, then rcirc-filter might be called more than once before its
previous invocation has managed to clear rcirc-process-output.

In other words, subsequent invocations may see process output that is
already being handled by previous invocations, thus potentially printing
duplicate messages in the process buffer.

Patch addressing this to follow.

Thanks,

-- 
Basil

In GNU Emacs 27.0.50 (build 31, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-10-24 built on thunk
Repository revision: 00027ff9d0f646662458bdb47cc7e2214f439698
Windowing system distributor 'The X.Org Foundation', version 11.0.12001000
System Description: Debian GNU/Linux buster/sid

Configured using:
 'configure --config-cache --prefix=/home/blc/.local --with-mailutils
 --with-x-toolkit=lucid --with-modules --with-file-notification=yes
 --with-x 'CC=ccache gcc' 'CFLAGS=-O2 -march=native -pipe''

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS
GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT
ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD
JSON LCMS2 GMP





             reply	other threads:[~2018-10-25  3:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  3:02 Basil L. Contovounesios [this message]
2018-10-25  3:07 ` bug#33145: 27.0.50; rcirc race receives duplicate messages Basil L. Contovounesios
2018-11-03  8:47   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhv2g244.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=33145@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.