bug#33233: 27.0.50; Replace gnus-correct-length with string-width

bug#33233: 27.0.50; Replace gnus-correct-length with string-width

[Eric Abrahamsen]

[-- Attachment #1: Type: text/plain, Size: 87 bytes --]


The one is trivially replaceable by the other, this patch defines an
obsolete alias.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Obsolete-gnus-correct-length-in-favor-of-string-widt.patch --]
[-- Type: text/x-patch, Size: 935 bytes --]

From 93e9566ee7335a148e34ecade9b716a636b5e70b Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Thu, 1 Nov 2018 16:50:17 -0700
Subject: [PATCH] Obsolete gnus-correct-length in favor of string-width

* lisp/gnus/gnus-spec.el: Define an obsolete alias.
---
 lisp/gnus/gnus-spec.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/gnus/gnus-spec.el b/lisp/gnus/gnus-spec.el
index 379a7f2b5c..4b5f15fbc6 100644
--- a/lisp/gnus/gnus-spec.el
+++ b/lisp/gnus/gnus-spec.el
@@ -271,9 +271,7 @@ gnus-spec-tab
 	       (insert " ")))
 	 (insert-char ?  (max (- ,column (current-column)) 0))))))
 
-(defun gnus-correct-length (string)
-  "Return the correct width of STRING."
-  (apply #'+ (mapcar #'char-width string)))
+(define-obsolete-function-alias 'gnus-correct-length 'string-width "27.1")
 
 (defun gnus-correct-substring (string start &optional end)
   (let ((wstart 0)
-- 
2.19.1

bug#33233: 27.0.50; Replace gnus-correct-length with string-width

[Eric Abrahamsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> The one is trivially replaceable by the other, this patch defines an
> obsolete alias.

Oh, in this situation should I be replacing the `gnus-correct-length'
calls with `string-width' directly, and just leaving the alias behind?

bug#33233: 27.0.50; Replace gnus-correct-length with string-width

[Eli Zaretskii]

> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Date: Thu, 01 Nov 2018 20:05:09 -0700
> 
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> 
> > The one is trivially replaceable by the other, this patch defines an
> > obsolete alias.
> 
> Oh, in this situation should I be replacing the `gnus-correct-length'
> calls with `string-width' directly, and just leaving the alias behind?

Yes, I think so.

bug#33233: 27.0.50; Replace gnus-correct-length with string-width

[Eric Abrahamsen]

Eli Zaretskii <eliz@gnu.org> writes:

>>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Date: Thu, 01 Nov 2018 20:05:09 -0700
>> 
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>> 
>> > The one is trivially replaceable by the other, this patch defines an
>> > obsolete alias.
>> 
>> Oh, in this situation should I be replacing the `gnus-correct-length'
>> calls with `string-width' directly, and just leaving the alias behind?
>
> Yes, I think so.

Weirdly, it doesn't seem to be used anywhere anymore. I guess the alias
should still go in for a while, though; I'll push this to master.

bug#33233: 27.0.50; Replace gnus-correct-length with string-width

[Eric Abrahamsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>>> Date: Thu, 01 Nov 2018 20:05:09 -0700
>>> 
>>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>> 
>>> > The one is trivially replaceable by the other, this patch defines an
>>> > obsolete alias.
>>> 
>>> Oh, in this situation should I be replacing the `gnus-correct-length'
>>> calls with `string-width' directly, and just leaving the alias behind?
>>
>> Yes, I think so.
>
> Weirdly, it doesn't seem to be used anywhere anymore. I guess the alias
> should still go in for a while, though; I'll push this to master.

Pushed