From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: van@scratch.space, 33398-done@debbugs.gnu.org
Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion
Date: Fri, 21 Dec 2018 01:01:00 +0200 [thread overview]
Message-ID: <87zhszdcr7.fsf@mail.linkov.net> (raw)
In-Reply-To: <834lb8ch4k.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 20 Dec 2018 18:11:55 +0200")
>> > (defface hi-redgold
>> > '((((min-colors 8)) (:background "red"))
>> > (t (:background "gold")))
>> > "Face for hi-lock mode."
>> > :group 'hi-lock-faces)
>> >
>> > I see no reason to use "red" on 16-color terminals, nor "orange" on
>> > color TTYs with at least 88 colors. The translation of "gold" should
>> > be good enough in those cases. Isn't it?
>>
>> I tried, and it used "red" even on 88-colors.
>
> I don't have access to such a terminal, but on a 16-color TTY "gold"
> displays as bright yellow, which is definitely not red. So I'm
> surprised you see red on a 88-color TTY.
Actually, I meant that I see red on a 88-color graphical display.
>> But given that LightSalmon is a good choice, I copied the same
>> definitions from other faces, substituted with new colors and they
>> look good on all environments:
>>
>> (defface hi-salmon
>> '((((min-colors 88) (background dark))
>> (:background "light salmon" :foreground "black"))
>> (((background dark)) (:background "red" :foreground "black"))
>> (((min-colors 88)) (:background "light salmon"))
>> (t (:background "red")))
>> "Face for hi-lock mode."
>> :group 'hi-lock-faces)
>>
>> (defface hi-aquamarine
>> '((((min-colors 88) (background dark))
>> (:background "aquamarine" :foreground "black"))
>> (((background dark)) (:background "blue" :foreground "black"))
>> (((min-colors 88)) (:background "aquamarine"))
>> (t (:background "blue")))
>> "Face for hi-lock mode."
>> :group 'hi-lock-faces)
>
> Thanks.
Installed to master and closed. It seems there is no need to update NEWS
because the users will see themselves two new colors added.
prev parent reply other threads:[~2018-12-20 23:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 12:58 bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Van L
2018-11-15 21:25 ` Juri Linkov
2018-11-15 22:13 ` Van L
2018-11-17 20:54 ` Juri Linkov
2018-11-19 3:10 ` Van L
2018-11-19 21:58 ` Juri Linkov
2018-11-20 4:00 ` Van L
2018-11-20 22:59 ` Juri Linkov
2018-11-21 12:23 ` Van L
2018-11-21 22:56 ` Juri Linkov
2018-11-22 0:32 ` Van L
2018-11-22 22:16 ` Juri Linkov
2018-11-23 0:56 ` Van L
2018-11-23 8:38 ` Eli Zaretskii
2018-11-23 11:22 ` Van L
2018-11-23 15:54 ` Eli Zaretskii
2018-11-23 8:35 ` Eli Zaretskii
2018-11-24 21:29 ` Juri Linkov
2018-11-25 16:46 ` Eli Zaretskii
2018-11-25 20:25 ` Juri Linkov
2018-11-26 16:01 ` Eli Zaretskii
2018-11-26 23:27 ` Juri Linkov
2018-11-27 5:56 ` Eli Zaretskii
2018-11-27 23:49 ` Juri Linkov
2018-11-28 23:06 ` Juri Linkov
2018-11-29 7:32 ` Eli Zaretskii
2018-11-29 22:29 ` Juri Linkov
2018-11-30 7:16 ` Eli Zaretskii
2018-12-19 0:36 ` Juri Linkov
2018-12-19 3:50 ` Van L
2018-12-19 21:37 ` Juri Linkov
2018-12-19 15:19 ` Eli Zaretskii
2018-12-19 21:40 ` Juri Linkov
2018-12-20 0:16 ` Van L
2018-12-20 16:11 ` Eli Zaretskii
2018-12-20 23:01 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhszdcr7.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=33398-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=van@scratch.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.