From: "João Távora" <joaotavora@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 33870@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#33870: 27.0.50; xref-goto-xref not configurable
Date: Tue, 08 Jan 2019 01:04:49 +0000 [thread overview]
Message-ID: <87zhscklhq.fsf@gmail.com> (raw)
In-Reply-To: <874lak9kr0.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 08 Jan 2019 00:16:19 +0200")
Juri Linkov <juri@linkov.net> writes:
> Of course, it doesn't work if you tried it only with part of my changes.
> When I submitted my initial patch, I tested it in all your test cases,
> including the above test case that was not broken with my patch.
You are correct. I was testing under the assumption that making
xref-goto-xref configurable didn't require the "tiny window" for
xref-find-definitions, which is something you stated that you wanted to
do for other xref.el commands like xref-find-references.
Anyway, can't you add the tiny window xref-find-definitions and the
other UI changes as an addon to *my* patch?
> But you asked to break my patch to several pieces and submit them
> separately to different bug reports. No wonder that each of them
> doesn't do what the whole patch did.
>> Expected xref.el to appear in the bottom window which was my original
>> intent when I said "other window".
> Then the xref buffer is obscured by another buffer visited in the same
> window, and if the user wants to visit more hits from the xref buffer,
> this is not easy to do.
>> In the current master this works OK, in your patch it doesn't.
>
> My initial patch solved this problem gracefully by creating a new window
> for the xref buffer.
You may well call this a problem, but it's not a bug. It's the defined
behaviour, it's like this by design. We are trying to create the
conditions that would enable you, or any other user, to create
alternative ways to present *xref* that have other advantages and
drawbacks.
>> I've also renamed window.el's window--display-buffer to
>> window-display-buffer throughout Emacs (i.e. made it public).
> You can't rename old functions lightly. This will break the existing
> code.
What other code? I renamed the uses in Emacs too: do you mean code
outside Emacs? It shouldn't be using that internal function in the
first place. But if it is, no reason to punish it: we can just provide
a deprecated function alias, which will at most warn its developers of
the imprudency.
No. I can because they were internal functions that no-one was supposed
to have been using in the first place. *That* is precisely why internal
functions are useful, so you can decide when and if to make them public.
You may argue that by making them public *now* we are going to have a
more deprecation problem if we decide to rename them again *in the
future*. I would agree with you there.
>> After we merge this, we can continue the discussion about the changing
>> the xref UI in the other bug you opened, bug#33992
> Better start with bug#33992 because it supports the above test case,
> then we could finish this bug#33870.
No. There is consensus on fixing the bug (xref.el doesn't respect
display-buffer-alist et al) without changing the UI. There is no
consensus on changing the UI.
Also I think some would not really view this is a bug at all.
It would seem Juri that you are trying to shoehorn a behaviour change
into a bugfix. Both things have less chances to go into Emacs that way.
I'm sure that:
* you can implement the UI changes that you want on top of my patch;
* you can make them optional;
* we can then agree on a good default.
Is that not so?
João
next prev parent reply other threads:[~2019-01-08 1:04 UTC|newest]
Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 20:42 bug#33870: 27.0.50; xref-goto-xref not configurable Juri Linkov
2018-12-26 2:10 ` Dmitry Gutov
2018-12-26 14:48 ` João Távora
2018-12-26 23:18 ` Juri Linkov
2018-12-27 0:05 ` João Távora
2018-12-27 13:20 ` Dmitry Gutov
2018-12-27 18:08 ` João Távora
2018-12-27 21:21 ` Juri Linkov
2018-12-27 23:23 ` Dmitry Gutov
2018-12-27 23:47 ` Juri Linkov
2018-12-28 0:35 ` Dmitry Gutov
2018-12-28 9:25 ` João Távora
2018-12-27 21:19 ` Juri Linkov
2018-12-27 21:49 ` João Távora
2018-12-27 1:12 ` making xref.el a core ELPA package Dmitry Gutov
2018-12-27 17:59 ` João Távora
2018-12-27 20:12 ` Juri Linkov
2018-12-27 21:41 ` João Távora
2018-12-28 14:32 ` Stefan Monnier
2018-12-28 16:28 ` João Távora
2019-01-03 0:18 ` bug#33870: 27.0.50; xref-goto-xref not configurable Juri Linkov
2019-01-03 13:50 ` Eli Zaretskii
2019-01-03 14:24 ` João Távora
2019-01-03 21:29 ` Juri Linkov
2019-01-03 22:08 ` João Távora
2019-01-04 0:07 ` Juri Linkov
2019-01-04 0:42 ` Dmitry Gutov
2019-01-04 7:41 ` João Távora
2019-01-04 6:55 ` Eli Zaretskii
2019-01-05 23:23 ` Juri Linkov
2019-01-06 9:03 ` martin rudalics
2019-01-06 20:55 ` Drew Adams
2019-01-06 23:52 ` Juri Linkov
2019-01-06 23:48 ` Juri Linkov
2019-01-07 9:03 ` martin rudalics
2019-01-07 22:02 ` Juri Linkov
2019-01-08 9:24 ` martin rudalics
2019-01-09 0:15 ` Juri Linkov
2019-01-09 10:04 ` martin rudalics
2019-01-09 23:40 ` Juri Linkov
2019-01-10 10:19 ` martin rudalics
2019-01-10 21:56 ` Juri Linkov
2019-01-11 9:24 ` martin rudalics
2019-01-13 0:33 ` Juri Linkov
2019-01-13 8:34 ` martin rudalics
2019-01-13 21:32 ` Juri Linkov
2019-01-14 7:57 ` martin rudalics
2019-01-19 20:47 ` Juri Linkov
2019-01-20 9:14 ` martin rudalics
2019-01-20 20:46 ` Juri Linkov
2019-01-21 7:52 ` martin rudalics
2019-01-21 20:59 ` Juri Linkov
2019-01-24 9:07 ` martin rudalics
2019-01-27 20:23 ` Juri Linkov
2019-01-28 18:38 ` martin rudalics
2019-01-28 20:07 ` Juri Linkov
2019-01-29 8:50 ` martin rudalics
2019-01-29 21:10 ` Juri Linkov
2019-01-29 21:46 ` Drew Adams
2019-01-30 21:06 ` Juri Linkov
2019-01-30 21:39 ` Drew Adams
2019-01-30 8:08 ` martin rudalics
2019-01-30 21:12 ` Juri Linkov
2019-01-31 8:32 ` martin rudalics
2019-01-31 21:07 ` Juri Linkov
2019-02-01 9:05 ` martin rudalics
2019-02-02 9:30 ` martin rudalics
2019-02-02 21:14 ` Juri Linkov
2019-02-03 20:22 ` Juri Linkov
2019-02-04 7:30 ` martin rudalics
2019-02-04 21:41 ` Juri Linkov
2019-02-05 8:36 ` martin rudalics
2019-02-17 21:14 ` Juri Linkov
2019-01-03 22:48 ` Dmitry Gutov
2019-01-04 0:12 ` Juri Linkov
2019-01-04 0:39 ` Dmitry Gutov
2019-01-03 22:49 ` Dmitry Gutov
2019-01-03 23:31 ` Dmitry Gutov
2019-01-04 0:14 ` Juri Linkov
2019-01-04 0:36 ` Dmitry Gutov
2019-01-04 7:49 ` João Távora
2019-01-05 23:17 ` Juri Linkov
2019-01-05 23:52 ` Dmitry Gutov
2019-01-05 23:27 ` Juri Linkov
2019-01-05 23:55 ` Dmitry Gutov
2019-01-07 14:21 ` João Távora
2019-01-07 22:16 ` Juri Linkov
2019-01-07 23:46 ` Dmitry Gutov
2019-01-08 0:23 ` Juri Linkov
2019-01-08 1:04 ` Dmitry Gutov
2019-01-08 1:04 ` João Távora [this message]
2019-01-08 9:25 ` martin rudalics
2019-01-08 11:17 ` João Távora
2019-01-08 14:47 ` martin rudalics
2019-01-08 14:55 ` João Távora
2019-01-08 14:44 ` Stefan Monnier
2019-01-08 15:04 ` martin rudalics
2019-01-08 16:06 ` Stefan Monnier
2019-01-08 17:43 ` martin rudalics
2019-01-08 20:53 ` Stefan Monnier
2019-01-09 10:03 ` martin rudalics
2019-01-09 13:14 ` Stefan Monnier
2019-01-09 13:27 ` martin rudalics
2019-01-10 10:19 ` martin rudalics
2019-01-09 0:20 ` Juri Linkov
2019-01-09 9:57 ` João Távora
2019-01-11 1:18 ` Dmitry Gutov
2019-01-13 0:41 ` Juri Linkov
2019-01-13 11:52 ` João Távora
2019-01-13 21:54 ` Juri Linkov
2019-01-13 23:06 ` João Távora
2019-01-18 2:32 ` Dmitry Gutov
2019-01-18 15:26 ` João Távora
2019-01-18 17:33 ` martin rudalics
2019-01-18 22:22 ` João Távora
2019-01-19 20:35 ` Juri Linkov
2019-01-20 9:14 ` martin rudalics
2019-01-19 20:31 ` Juri Linkov
2019-01-20 0:34 ` Dmitry Gutov
2019-01-20 20:44 ` Juri Linkov
2019-01-21 20:43 ` Juri Linkov
2019-01-22 0:07 ` Dmitry Gutov
2019-01-18 2:37 ` Dmitry Gutov
2019-01-18 15:22 ` João Távora
2019-01-18 15:35 ` Dmitry Gutov
2019-01-18 15:40 ` João Távora
2019-01-18 17:33 ` martin rudalics
2019-01-18 17:38 ` Dmitry Gutov
2019-01-19 20:45 ` Juri Linkov
2019-01-20 0:27 ` Dmitry Gutov
2019-01-20 0:31 ` João Távora
2019-01-27 20:29 ` Juri Linkov
2019-01-31 22:14 ` João Távora
2019-02-01 0:17 ` João Távora
2019-02-01 1:39 ` Dmitry Gutov
2019-02-01 7:30 ` Eli Zaretskii
2019-02-01 8:19 ` João Távora
2019-02-01 18:27 ` Drew Adams
2019-02-02 0:00 ` Dmitry Gutov
2019-02-02 0:29 ` Dmitry Gutov
2019-02-02 9:30 ` martin rudalics
2019-02-02 21:16 ` Juri Linkov
2019-02-02 22:22 ` João Távora
2019-02-03 3:37 ` Eli Zaretskii
2019-02-03 12:00 ` João Távora
2019-02-03 17:09 ` Eli Zaretskii
2019-02-03 20:22 ` João Távora
2019-02-05 18:12 ` Eli Zaretskii
2019-02-05 18:34 ` João Távora
2019-02-06 22:53 ` João Távora
2019-02-17 20:17 ` Juri Linkov
2019-02-03 21:02 ` Drew Adams
2019-02-03 20:33 ` Juri Linkov
2019-02-03 21:08 ` João Távora
2019-02-04 21:35 ` Juri Linkov
2019-02-04 23:24 ` João Távora
2019-02-05 13:44 ` Dmitry Gutov
2019-02-17 21:20 ` Juri Linkov
2019-02-22 2:17 ` Dmitry Gutov
2019-06-11 0:00 ` Dmitry Gutov
2019-06-16 0:52 ` Dmitry Gutov
2018-12-26 15:36 ` Eli Zaretskii
2018-12-26 23:17 ` Juri Linkov
2018-12-27 15:27 ` Eli Zaretskii
2018-12-27 20:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhscklhq.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=33870@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.