From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package proposal: visual-path-abbrev.el Date: Sat, 02 Mar 2019 15:59:00 +0100 Message-ID: <87zhqdpbkb.fsf@gnu.org> References: <87tvglpmcx.fsf@gnu.org> <83k1hhh5mb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="130753"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 02 15:59:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h066z-000Xsn-Tw for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 15:59:38 +0100 Original-Received: from localhost ([127.0.0.1]:55499 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h066y-000419-Ut for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 09:59:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h066R-0003dY-La for emacs-devel@gnu.org; Sat, 02 Mar 2019 09:59:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h066R-0004rg-Hp for emacs-devel@gnu.org; Sat, 02 Mar 2019 09:59:03 -0500 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:58963) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1h066R-0002mV-DO; Sat, 02 Mar 2019 09:59:03 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 19C4321D1E; Sat, 2 Mar 2019 09:59:03 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sat, 02 Mar 2019 09:59:03 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdejgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepvfgrshhsihhl ohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucfkphepleefrddvfeeirdduvd elrdehvdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghu thhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpe epghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Original-Received: from thinkpad-t440p (p5dec8134.dip0.t-ipconnect.de [93.236.129.52]) by mail.messagingengine.com (Postfix) with ESMTPA id B7E8CE405D; Sat, 2 Mar 2019 09:59:01 -0500 (EST) Mail-Followup-To: Eli Zaretskii , emacs-devel@gnu.org In-Reply-To: <83k1hhh5mb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Mar 2019 13:34:36 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233770 Archived-At: Eli Zaretskii writes: Hi Eli, > The GNU Coding Style conventions frown on using "path" for anything > but PATH-style directory lists. I think you mean "file names" here. Fine with me. >> - Sometimes when scrolling fast and then stopping, only parts of the >> visible buffer portion got the overlays applied. You can try >> triggering that problem by enabling the mode in a *grep* buffer and >> then scrolling a long way. > > Your code seems to update the overlays in a function called from > post-command-hook, but post-command-hook runs before redisplay updates > the window due to last command. So you are using stale window-start > and window-end values, and if the last command scrolls some file names > into the view, those file names might not have overlays on them. > > I think the preferred method is to use jit-lock-register to register > your function; see e.g. glasses.el for how this can be done. Yes, that looks good. I'll try that out. >> - When lines are wrapped around and line-move-visual is t, the mode can >> make the line short enough so that it doesn't wrap anymore. But >> still next-line moves point to where it would belong if the mode were >> not active, i.e., point jumps to somewhere on the same line. > > That sounds like a bug, so a minimal recipe to reproduce this (in a > bug report, please ;-) would be appreciated. Ok, I'll do that. Bye, Tassilo