From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package proposal: visual-path-abbrev.el
Date: Sat, 02 Mar 2019 15:59:00 +0100 [thread overview]
Message-ID: <87zhqdpbkb.fsf@gnu.org> (raw)
In-Reply-To: <83k1hhh5mb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Mar 2019 13:34:36 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
Hi Eli,
> The GNU Coding Style conventions frown on using "path" for anything
> but PATH-style directory lists. I think you mean "file names" here.
Fine with me.
>> - Sometimes when scrolling fast and then stopping, only parts of the
>> visible buffer portion got the overlays applied. You can try
>> triggering that problem by enabling the mode in a *grep* buffer and
>> then scrolling a long way.
>
> Your code seems to update the overlays in a function called from
> post-command-hook, but post-command-hook runs before redisplay updates
> the window due to last command. So you are using stale window-start
> and window-end values, and if the last command scrolls some file names
> into the view, those file names might not have overlays on them.
>
> I think the preferred method is to use jit-lock-register to register
> your function; see e.g. glasses.el for how this can be done.
Yes, that looks good. I'll try that out.
>> - When lines are wrapped around and line-move-visual is t, the mode can
>> make the line short enough so that it doesn't wrap anymore. But
>> still next-line moves point to where it would belong if the mode were
>> not active, i.e., point jumps to somewhere on the same line.
>
> That sounds like a bug, so a minimal recipe to reproduce this (in a
> bug report, please ;-) would be appreciated.
Ok, I'll do that.
Bye,
Tassilo
next prev parent reply other threads:[~2019-03-02 14:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 11:05 [ELPA] New package proposal: visual-path-abbrev.el Tassilo Horn
2019-03-02 11:34 ` Eli Zaretskii
2019-03-02 14:59 ` Tassilo Horn [this message]
2019-03-03 9:46 ` Tassilo Horn
2019-03-03 13:48 ` Stefan Monnier
2019-03-03 15:11 ` Eli Zaretskii
2019-03-03 15:52 ` Tassilo Horn
2019-03-03 17:18 ` Eli Zaretskii
2019-03-03 17:55 ` Tassilo Horn
2019-03-04 18:03 ` Eli Zaretskii
2019-03-05 10:01 ` Tassilo Horn
2019-03-05 16:21 ` Eli Zaretskii
2019-03-05 18:32 ` Tassilo Horn
2019-03-08 5:49 ` Stefan Monnier
2019-03-08 14:02 ` Tassilo Horn
2019-03-08 17:34 ` Tassilo Horn
2019-03-08 19:01 ` Stefan Monnier
2019-03-08 22:18 ` Stefan Monnier
2019-03-09 6:52 ` Tassilo Horn
2019-03-08 18:52 ` Stefan Monnier
2019-03-02 21:25 ` Leo Liu
2019-03-03 9:25 ` Tassilo Horn
2019-03-04 0:23 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhqdpbkb.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.