all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34908@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru
Subject: bug#34908: Push mark in xref-push-marker-stack
Date: Wed, 20 Mar 2019 23:49:09 +0200	[thread overview]
Message-ID: <87zhpp2onm.fsf@mail.linkov.net> (raw)
In-Reply-To: <83bm26t7bm.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Mar 2019 07:59:09 +0200")

>> I don't want to advertise this fix because the primary way to get back
>> for xref should be ‘M-,’.
>
> Well, it must be in NEWS, since this is a change in behavior.
>
> As for the manuals, it might be okay not to mention that, although I
> admit I don't understand your reasoning: something that is not a
> primary use doesn't automatically mean it shouldn't be documented.
>
>> Setting the mark is only needed for users who expect that every
>> significant change in position should leave a trace in the global
>> mark ring.
>
> I believe most of our commands that move to a far away position do set
> the mark.

Yes, most of these commands set the mark, but none of them mention this fact
in the manual.  I looked at

  (info "(emacs) Moving Point")
  (info "(emacs) Moving by Defuns")
  etc.

there is nothing about setting the mark, because it's so obvious
that doesn't need a special reminder for every command.

So I don't know what to write in NEWS, something along the lines:
"like all commands that move to a far away position
 xref-find-definitions now sets the mark as well
 but please remember that the primary way to pop xref mark
 is still M-, (xref-pop-marker-stack)" ?





  reply	other threads:[~2019-03-20 21:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 21:12 bug#34908: Push mark in xref-push-marker-stack Juri Linkov
2019-03-18 21:50 ` João Távora
2019-03-18 23:14 ` Dmitry Gutov
2019-03-19 21:02   ` Juri Linkov
2019-03-20  1:47     ` Dmitry Gutov
2019-03-20 21:59       ` Juri Linkov
2019-03-21  0:59         ` Dmitry Gutov
2019-03-19  6:16 ` Eli Zaretskii
2019-03-19 11:57   ` Dmitry Gutov
2019-03-19 20:59   ` Juri Linkov
2019-03-20  5:59     ` Eli Zaretskii
2019-03-20 21:49       ` Juri Linkov [this message]
2019-03-21  3:35         ` Eli Zaretskii
2019-03-24 21:20           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhpp2onm.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=34908@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.