From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Deus Max Newsgroups: gmane.emacs.bugs Subject: bug#34973: 27.0.50; gnus-summary-move-article fails due to remhash Date: Mon, 25 Mar 2019 02:09:02 +0200 Message-ID: <87zhpju869.fsf@aia00054aia.gr> References: <87a7hka0m4.fsf@aia00054aia.gr> <875zs82ukz.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="25324"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34973@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 25 01:17:38 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8DJ3-0006Pd-T5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Mar 2019 01:17:38 +0100 Original-Received: from localhost ([127.0.0.1]:34190 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8DJ2-00018X-Ot for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 20:17:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8DIs-00016Y-7V for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 20:17:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8DBj-0004y8-DO for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 20:10:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43741) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8DBj-0004y3-81 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 20:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h8DBh-0008Jv-Mh; Sun, 24 Mar 2019 20:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Deus Max Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Mon, 25 Mar 2019 00:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34973 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 34973-submit@debbugs.gnu.org id=B34973.155347255631928 (code B ref 34973); Mon, 25 Mar 2019 00:10:01 +0000 Original-Received: (at 34973) by debbugs.gnu.org; 25 Mar 2019 00:09:16 +0000 Original-Received: from localhost ([127.0.0.1]:57284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8DAy-0008Iu-1b for submit@debbugs.gnu.org; Sun, 24 Mar 2019 20:09:16 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:48983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8DAw-0008Ig-QW for 34973@debbugs.gnu.org; Sun, 24 Mar 2019 20:09:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1553472547; bh=kh/t75phXPyaZ4MBplKHQaAZkUip+nJnMFj8Z3uzcEM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lMYyKQzUy8a1QtpsO0ZX2DDKStl9MrQDk83y9oJKqgpYRb7xUW1cANTR2548mPGm5 PrwFYagLD/juP/tbeSLy8v7pMTwfy7zxJmCQWGNFmes035HgTMcT22WxxM9FLs1z0I AM+3+92UuOpyYiIQIsDB/c0Zm16itQ+EOralQt50= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from dellcorei5dias ([37.153.151.218]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MgtWa-1hLSjr20I4-00M5x8; Mon, 25 Mar 2019 01:09:07 +0100 In-Reply-To: <875zs82ukz.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 24 Mar 2019 14:52:28 +0000") X-Provags-ID: V03:K1:13wL1VmokMMsZ2jAz0DbMBsyGlOsmeVTV/SOuu+KLizY/WG5HKS qhZsf8+AtVYd+QyrJkThauQnpJKRZys3rIvzqrbnwhoXHSR2mWfem2spJospJ3kIbcEJqnO k17CHpiuAEmBA0q7UHZPCr0w6PcGrZR+4ol4G/U0x7L+kfSfXTBM4Kve6FjAsvIw+c8txLi AHNPz/FAU6SW38dMMbIuQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:jvMNb/5Jhho=:pzuxO6xev0ORtme8z/rzb8 WZzBKnXCpV0I+edidi7vYqbVrlOKZri2JcgWv9jMBVZHszYSBw13e5eCPLWxfDRg+UFvJNh+b g6HDFBhtg2g8x0uVMz+4Ns08YM1MzZppHW4RC4MvqYaPB4FkvVdsFz5pqWnnIHr/uVUP8yxL5 q6UNsgH21u8I5h8hRjaJZxfryOAi+yinTn969S8TJQW6J0Kb14WtmuL1pEa6oaj2m9/07V0WW Et3ftTJ6tdxopHWEqdQIwXpwjIhytq4Aez2k9hXWjE9OpZjDNj9xkPrDn4OxU0xPF+lZZAbDe rn8VPWyF51dmpH0ed1qHJowqfXrnQZ9SKXlqN+N5RnNMyRVyqYZOJSdFuhA+T8uXs52hPPhJJ 4DgENuzD6uTI+upVfMJjjFC87tY0czsWvwVCwWPVDq7AOYxaLyUBpHf14y7aQ205rxmipEaN7 FJyjINPaZhtB/CaJbIC+BmMlwJ8MEwTqrcna9P8HneUBYlSqaY9Td0Ov3YcGRkWD6JA/K0mGX vRsUMjaIUn23ijPlbWxdfdyDrh56s67rSueie7MFmuRtfU+on4C6XplTzMMQy1whdNcS0cgJn tYkAwRiQKrPyXjhY1ASEFZSlZq21yvti+MUz7ZHlLBbk5jErPOBDtIC6x66Y3bCQA/jXcfR8l ihNvMhUmjbQw5DrPm3GyPea80IhuxfXWp945hvb0+Z38xUR1ayHrQErKH7d6kvnfiVV5J2IDY WSoapEv4s1+YRCBIBZ74lNNwSL+OLuh/13724zc94q/C0fffu+f6LBGlNe3BPE0Z//xjqpzU X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156727 Archived-At: On Sun, Mar 24 2019, Basil L. Contovounesios wrote: > tags 34973 patch > quit > > > > Deus Max writes: > >> Reading the manual >> (https://www.gnu.org/software/emacs/manual/html_node/elisp/Hash-Access.html#Hash-Access) >> on remhash, it says: "In Emacs Lisp, remhash always returns nil.", so I >> modified the calling function gnus-dup-unsuppress-article in gnus-dup.el, as follows: >> >> 157c157,159 >> < (remhash id gnus-dup-hashtb)))) >> --- >>> (if (hash-table-p gnus-dup-hashtb) >>> (remhash id gnus-dup-hashtb) >>> nil)))) >> >> This patch seems to have fixed the problem and now >> gnus-summary-move-article works fine. ! >> the value of gnus-dup-hashtb was nil, for the problem runs. > > The return value of gnus-dup-unsuppress-article doesn't matter, only > that remhash not be passed a nil gnus-dup-hashtb. > > In other words, gnus-dup-unsuppress-article should either not be called > or should handle the case when it is called before gnus-dup-open has > initialised gnus-dup-hashtb. > > I attach a patch which follows the apparent gnus-sum.el convention of > guarding calls to gnus-dup.el functions based on the value of > gnus-suppress-duplicates. > Of course, much better. Thank you. > This fixes the immediate issue at hand, but I think there may still be a > problem when gnus-suppress-duplicates is enabled at a later time. I > think that deserves a separate bug report, though. > > Thanks,