* org-eldoc error on shell src blocks @ 2018-02-02 1:32 numbchild 2018-02-04 7:42 ` numbchild 0 siblings, 1 reply; 6+ messages in thread From: numbchild @ 2018-02-02 1:32 UTC (permalink / raw) To: Org-mode [-- Attachment #1: Type: text/plain, Size: 6548 bytes --] When I enable `eldoc-mode` in org-mode. eldoc timer running when on `shell` src blocks like: #+begin_src shell git log $rev..origin/emacs-25 -- lisp/org doc/misc/org.texi \ etc/refcards/orgcard.tex etc/ORG-NEWS etc/org \ etc/schema/od-manifest-schema-v1.2-os.rnc \ etc/schema/od-schema-v1.2-os.rnc #+end_src I got the following error. #+begin_example Debugger entered--Lisp error: (wrong-type-argument processp nil) process-command(nil) shell-mode() funcall(shell-mode) (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) (unwind-protect (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))) (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) doc-func) (if (fboundp mode-func) (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) doc-func)) (if (eq 'empty cached-func) (if (fboundp mode-func) (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) doc-func)) cached-func) (let ((cached-func (gethash lang org-eldoc-local-functions-cache 'empty)) (mode-func (intern-soft (format "%s-mode" lang))) doc-func) (if (eq 'empty cached-func) (if (fboundp mode-func) (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) doc-func)) cached-func)) org-eldoc-get-mode-local-documentation-function("shell") (let ((doc-fun (org-eldoc-get-mode-local-documentation-function lang))) (if (functionp doc-fun) (progn (funcall doc-fun)))) (cond ((or (string= lang "emacs-lisp") (string= lang "elisp")) (if (fboundp 'elisp-eldoc-documentation-function) (elisp-eldoc-documentation-function) (let (eldoc-documentation-function) (eldoc-print-current-symbol-info)))) ((or (string= lang "c") (string= lang "C")) (if (require 'c-eldoc nil t) (progn (c-eldoc-print-current-symbol-info)))) ((string= lang "css") (if (require 'css-eldoc nil t) (progn (css-eldoc-function)))) ((string= lang "php") (if (require 'php-eldoc nil t) (progn (php-eldoc-function)))) ((or (string= lang "go") (string= lang "golang")) (if (require 'go-eldoc nil t) (progn (go-eldoc--documentation-function)))) (t (let ((doc-fun (org-eldoc-get-mode-local-documentation-function lang))) (if (functionp doc-fun) (progn (funcall doc-fun)))))) (let ((lang (org-eldoc-get-src-lang))) (cond ((or (string= lang "emacs-lisp") (string= lang "elisp")) (if (fboundp 'elisp-eldoc-documentation-function) (elisp-eldoc-documentation-function) (let (eldoc-documentation-function) (eldoc-print-current-symbol-info)))) ((or (string= lang "c") (string= lang "C")) (if (require 'c-eldoc nil t) (progn (c-eldoc-print-current-symbol-info)))) ((string= lang "css") (if (require 'css-eldoc nil t) (progn (css-eldoc-function)))) ((string= lang "php") (if (require 'php-eldoc nil t) (progn (php-eldoc-function)))) ((or (string= lang "go") (string= lang "golang")) (if (require 'go-eldoc nil t) (progn (go-eldoc--documentation-function)))) (t (let ((doc-fun (org-eldoc-get-mode-local-documentation-function lang))) (if (functionp doc-fun) (progn (funcall doc-fun))))))) (or (org-eldoc-get-breadcrumb) (org-eldoc-get-src-header) (let ((lang (org-eldoc-get-src-lang))) (cond ((or (string= lang "emacs-lisp") (string= lang "elisp")) (if (fboundp 'elisp-eldoc-documentation-function) (elisp-eldoc-documentation-function) (let (eldoc-documentation-function) (eldoc-print-current-symbol-info)))) ((or (string= lang "c") (string= lang "C")) (if (require 'c-eldoc nil t) (progn (c-eldoc-print-current-symbol-info)))) ((string= lang "css") (if (require 'css-eldoc nil t) (progn (css-eldoc-function)))) ((string= lang "php") (if (require 'php-eldoc nil t) (progn (php-eldoc-function)))) ((or (string= lang "go") (string= lang "golang")) (if (require 'go-eldoc nil t) (progn (go-eldoc--documentation-function)))) (t (let ((doc-fun (org-eldoc-get-mode-local-documentation-function lang))) (if (functionp doc-fun) (progn (funcall doc-fun)))))))) org-eldoc-documentation-function() eldoc-print-current-symbol-info() #f(compiled-function () #<bytecode 0x27fd5d>)() apply(#f(compiled-function () #<bytecode 0x27fd5d>) nil) timer-event-handler([t 0 0 500000 nil #f(compiled-function () #<bytecode 0x27fd5d>) nil idle 0]) #+end_example [stardiviner] <Hack this world!> GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ [-- Attachment #2: Type: text/html, Size: 7699 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: org-eldoc error on shell src blocks 2018-02-02 1:32 org-eldoc error on shell src blocks numbchild @ 2018-02-04 7:42 ` numbchild 2018-02-04 7:55 ` Nicolas Goaziou 0 siblings, 1 reply; 6+ messages in thread From: numbchild @ 2018-02-04 7:42 UTC (permalink / raw) To: Org-mode [-- Attachment #1: Type: text/plain, Size: 7497 bytes --] After some dive in deeper - [X] emacs minimal init test, confirmed issue in org-mode. - [X] from the error log, seems `org-eldoc` try to call `(progn (funcall mode-func) ...`. This caused `shell-mode()`. - [ ] check out `org-eldoc.el` source code, have not found any solution or options. Hope some org-mode hacker can help to fix this issue? And this might be a unit test in Org-mode testing? [stardiviner] <Hack this world!> GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Fri, Feb 2, 2018 at 9:32 AM, numbchild@gmail.com <numbchild@gmail.com> wrote: > When I enable `eldoc-mode` in org-mode. > eldoc timer running when on `shell` src blocks like: > > #+begin_src shell > git log $rev..origin/emacs-25 -- lisp/org doc/misc/org.texi \ > etc/refcards/orgcard.tex etc/ORG-NEWS etc/org \ > etc/schema/od-manifest-schema-v1.2-os.rnc \ > etc/schema/od-schema-v1.2-os.rnc > #+end_src > > I got the following error. > > #+begin_example > Debugger entered--Lisp error: (wrong-type-argument processp nil) > process-command(nil) > shell-mode() > funcall(shell-mode) > (progn (funcall mode-func) (setq doc-func (and > eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) > (puthash lang doc-func org-eldoc-local-functions-cache)) > (unwind-protect (progn (funcall mode-func) (setq doc-func (and > eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) > (puthash lang doc-func org-eldoc-local-functions-cache)) (and > (buffer-name temp-buffer) (kill-buffer temp-buffer))) > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (funcall mode-func) (setq doc-func (and eldoc-documentation-function > (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func > org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) > (kill-buffer temp-buffer)))) > (let ((temp-buffer (generate-new-buffer " *temp*"))) > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (funcall mode-func) (setq doc-func (and eldoc-documentation-function > (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func > org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) > (kill-buffer temp-buffer))))) > (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (funcall mode-func) (setq doc-func (and eldoc-documentation-function > (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func > org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) > (kill-buffer temp-buffer))))) doc-func) > (if (fboundp mode-func) (progn (let ((temp-buffer (generate-new-buffer " > *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect > (progn (funcall mode-func) (setq doc-func (and eldoc-documentation-function > (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func > org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) > (kill-buffer temp-buffer))))) doc-func)) > (if (eq 'empty cached-func) (if (fboundp mode-func) (progn (let > ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer > (set-buffer temp-buffer) (unwind-protect (progn (funcall mode-func) (setq > doc-func (and eldoc-documentation-function (symbol-value > 'eldoc-documentation-function))) (puthash lang doc-func > org-eldoc-local-functions-cache)) (and (buffer-name temp-buffer) > (kill-buffer temp-buffer))))) doc-func)) cached-func) > (let ((cached-func (gethash lang org-eldoc-local-functions-cache > 'empty)) (mode-func (intern-soft (format "%s-mode" lang))) doc-func) (if > (eq 'empty cached-func) (if (fboundp mode-func) (progn (let ((temp-buffer > (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer > temp-buffer) (unwind-protect (progn (funcall mode-func) (setq doc-func (and > eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) > (puthash lang doc-func org-eldoc-local-functions-cache)) (and > (buffer-name temp-buffer) (kill-buffer temp-buffer))))) doc-func)) > cached-func)) > org-eldoc-get-mode-local-documentation-function("shell") > (let ((doc-fun (org-eldoc-get-mode-local-documentation-function lang))) > (if (functionp doc-fun) (progn (funcall doc-fun)))) > (cond ((or (string= lang "emacs-lisp") (string= lang "elisp")) (if > (fboundp 'elisp-eldoc-documentation-function) (elisp-eldoc-documentation-function) > (let (eldoc-documentation-function) (eldoc-print-current-symbol-info)))) > ((or (string= lang "c") (string= lang "C")) (if (require 'c-eldoc nil t) > (progn (c-eldoc-print-current-symbol-info)))) ((string= lang "css") (if > (require 'css-eldoc nil t) (progn (css-eldoc-function)))) ((string= lang > "php") (if (require 'php-eldoc nil t) (progn (php-eldoc-function)))) ((or > (string= lang "go") (string= lang "golang")) (if (require 'go-eldoc nil t) > (progn (go-eldoc--documentation-function)))) (t (let ((doc-fun > (org-eldoc-get-mode-local-documentation-function lang))) (if (functionp > doc-fun) (progn (funcall doc-fun)))))) > (let ((lang (org-eldoc-get-src-lang))) (cond ((or (string= lang > "emacs-lisp") (string= lang "elisp")) (if (fboundp > 'elisp-eldoc-documentation-function) (elisp-eldoc-documentation-function) > (let (eldoc-documentation-function) (eldoc-print-current-symbol-info)))) > ((or (string= lang "c") (string= lang "C")) (if (require 'c-eldoc nil t) > (progn (c-eldoc-print-current-symbol-info)))) ((string= lang "css") (if > (require 'css-eldoc nil t) (progn (css-eldoc-function)))) ((string= lang > "php") (if (require 'php-eldoc nil t) (progn (php-eldoc-function)))) ((or > (string= lang "go") (string= lang "golang")) (if (require 'go-eldoc nil t) > (progn (go-eldoc--documentation-function)))) (t (let ((doc-fun > (org-eldoc-get-mode-local-documentation-function lang))) (if (functionp > doc-fun) (progn (funcall doc-fun))))))) > (or (org-eldoc-get-breadcrumb) (org-eldoc-get-src-header) (let ((lang > (org-eldoc-get-src-lang))) (cond ((or (string= lang "emacs-lisp") (string= > lang "elisp")) (if (fboundp 'elisp-eldoc-documentation-function) > (elisp-eldoc-documentation-function) (let (eldoc-documentation-function) > (eldoc-print-current-symbol-info)))) ((or (string= lang "c") (string= > lang "C")) (if (require 'c-eldoc nil t) (progn > (c-eldoc-print-current-symbol-info)))) ((string= lang "css") (if (require > 'css-eldoc nil t) (progn (css-eldoc-function)))) ((string= lang "php") (if > (require 'php-eldoc nil t) (progn (php-eldoc-function)))) ((or (string= > lang "go") (string= lang "golang")) (if (require 'go-eldoc nil t) (progn > (go-eldoc--documentation-function)))) (t (let ((doc-fun > (org-eldoc-get-mode-local-documentation-function lang))) (if (functionp > doc-fun) (progn (funcall doc-fun)))))))) > org-eldoc-documentation-function() > eldoc-print-current-symbol-info() > #f(compiled-function () #<bytecode 0x27fd5d>)() > apply(#f(compiled-function () #<bytecode 0x27fd5d>) nil) > timer-event-handler([t 0 0 500000 nil #f(compiled-function () #<bytecode > 0x27fd5d>) nil idle 0]) > #+end_example > > > [stardiviner] <Hack this world!> GPG key ID: 47C32433 > IRC(freeenode): stardiviner Twitter: @numbchild > Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 > Blog: http://stardiviner.github.io/ > [-- Attachment #2: Type: text/html, Size: 9731 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: org-eldoc error on shell src blocks 2018-02-04 7:42 ` numbchild @ 2018-02-04 7:55 ` Nicolas Goaziou 2019-03-31 8:53 ` 甲斐常伸 0 siblings, 1 reply; 6+ messages in thread From: Nicolas Goaziou @ 2018-02-04 7:55 UTC (permalink / raw) To: numbchild@gmail.com; +Cc: Łukasz Gruner, Org-mode Hello, "numbchild@gmail.com" <numbchild@gmail.com> writes: > After some dive in deeper > > - [X] emacs minimal init test, confirmed issue in org-mode. > - [X] from the error log, seems `org-eldoc` try to call `(progn (funcall > mode-func) ...`. This caused `shell-mode()`. > - [ ] check out `org-eldoc.el` source code, have not found any solution or > options. > Hope some org-mode hacker can help to fix this issue? I'm Cc'ing Org Eldoc author about it. > And this might be a unit test in Org-mode testing? We don't test contrib packages. However, they can provide their own tests. Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: org-eldoc error on shell src blocks 2018-02-04 7:55 ` Nicolas Goaziou @ 2019-03-31 8:53 ` 甲斐常伸 2019-04-04 15:14 ` Takaaki Ishikawa 0 siblings, 1 reply; 6+ messages in thread From: 甲斐常伸 @ 2019-03-31 8:53 UTC (permalink / raw) To: Nicolas Goaziou; +Cc: Łukasz Gruner, Org-mode [-- Attachment #1: Type: text/plain, Size: 3258 bytes --] Hello, I encounted the same error and I found it happens because "org-eldoc.el" doesn't reflect a value of "org-src-lang-modes". When I redefine "org-eldoc-get-mode-local-documentation-function" to reflect a value of "org-src-lang-modes" as below, the error disappeared. (defun org-eldoc-get-mode-local-documentation-function (lang) "Check if LANG-mode sets eldoc-documentation-function and return its value." (let ((cached-func (gethash lang org-eldoc-local-functions-cache 'empty)) (mode-func (org-src--get-lang-mode lang)) doc-func) (if (eq 'empty cached-func) (when (fboundp mode-func) (with-temp-buffer (funcall mode-func) (setq doc-func (and eldoc-documentation-function (symbol-value 'eldoc-documentation-function))) (puthash lang doc-func org-eldoc-local-functions-cache)) doc-func) cached-func))) The practical change is a one line. diff --git a/contrib/lisp/org-eldoc.el b/contrib/lisp/org-eldoc.el index 556b945..fca13c3 100644 --- a/contrib/lisp/org-eldoc.el +++ b/contrib/lisp/org-eldoc.el @@ -110,7 +110,7 @@ (defun org-eldoc-get-mode-local-documentation-function (lang) "Check if LANG-mode sets eldoc-documentation-function and return its value." (let ((cached-func (gethash lang org-eldoc-local-functions-cache 'empty)) - (mode-func (intern-soft (format "%s-mode" lang))) + (mode-func (org-src--get-lang-mode lang)) doc-func) (if (eq 'empty cached-func) (when (fboundp mode-func) I confirmed this change works good on the following two environments. - Emacs 26.1 on Windows 10 - (emacs-version) ; GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-05-29 - (org-version) ; Org mode version 9.2.2 (9.2.2-13-g0007df-elpaplus @ /home/kai2nenobu/.emacs.d/elpa/org-plus-contrib-20190318/) - Emacs 26.1 on Ubuntu 18.04 on WSL (on above Windows 10) - (emacs-version) ; GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-31 - (org-version) ; Org mode version 9.2.1 (9.2.1-8-g1b1797-elpaplus @ c:/Users/kai2nenobu/.emacs.d/elpa/org-plus-contrib-20190211/) I'm ready to contribute this patch, but I don't know how to contribute to "org-eldoc.el". Please tell me how to do it. Best Regards, 2018年2月4日(日) 16:56 Nicolas Goaziou <mail@nicolasgoaziou.fr>: > Hello, > > "numbchild@gmail.com" <numbchild@gmail.com> writes: > > > After some dive in deeper > > > > - [X] emacs minimal init test, confirmed issue in org-mode. > > - [X] from the error log, seems `org-eldoc` try to call `(progn (funcall > > mode-func) ...`. This caused `shell-mode()`. > > - [ ] check out `org-eldoc.el` source code, have not found any solution > or > > options. > > > Hope some org-mode hacker can help to fix this issue? > > I'm Cc'ing Org Eldoc author about it. > > > And this might be a unit test in Org-mode testing? > > We don't test contrib packages. However, they can provide their own > tests. > > Regards, > > -- > Nicolas Goaziou > > [-- Attachment #2: Type: text/html, Size: 4242 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: org-eldoc error on shell src blocks 2019-03-31 8:53 ` 甲斐常伸 @ 2019-04-04 15:14 ` Takaaki Ishikawa 2019-04-07 7:18 ` Nicolas Goaziou 0 siblings, 1 reply; 6+ messages in thread From: Takaaki Ishikawa @ 2019-04-04 15:14 UTC (permalink / raw) To: 甲斐常伸 Cc: Łukasz Gruner, Org-mode, Nicolas Goaziou [-- Attachment #1: Type: text/plain, Size: 3727 bytes --] Hi folks, I just verified the proposed patch to org-eldoc.el in contrib dir, works well. But the problem is we lost an appropriate contact point because https://bitbucket.org/ukaszg/org-eldoc was removed. Who can amend org-eldoc.el in contribution directory? Best regards, Takaaki > On Mar 31, 2019, at 17:53, 甲斐常伸 <kai2nenobu@gmail.com> wrote: > > Hello, > > I encounted the same error and I found it happens because "org-eldoc.el" doesn't reflect a value of "org-src-lang-modes". When I redefine "org-eldoc-get-mode-local-documentation-function" to reflect a value of "org-src-lang-modes" as below, the error disappeared. > > (defun org-eldoc-get-mode-local-documentation-function (lang) > "Check if LANG-mode sets eldoc-documentation-function and return its value." > (let ((cached-func (gethash lang org-eldoc-local-functions-cache 'empty)) > (mode-func (org-src--get-lang-mode lang)) > doc-func) > (if (eq 'empty cached-func) > (when (fboundp mode-func) > (with-temp-buffer > (funcall mode-func) > (setq doc-func (and eldoc-documentation-function > (symbol-value 'eldoc-documentation-function))) > (puthash lang doc-func org-eldoc-local-functions-cache)) > doc-func) > cached-func))) > > The practical change is a one line. > > diff --git a/contrib/lisp/org-eldoc.el b/contrib/lisp/org-eldoc.el > index 556b945..fca13c3 100644 > --- a/contrib/lisp/org-eldoc.el > +++ b/contrib/lisp/org-eldoc.el > @@ -110,7 +110,7 @@ > (defun org-eldoc-get-mode-local-documentation-function (lang) > "Check if LANG-mode sets eldoc-documentation-function and return its value." > (let ((cached-func (gethash lang org-eldoc-local-functions-cache 'empty)) > - (mode-func (intern-soft (format "%s-mode" lang))) > + (mode-func (org-src--get-lang-mode lang)) > doc-func) > (if (eq 'empty cached-func) > (when (fboundp mode-func) > > > I confirmed this change works good on the following two environments. > > - Emacs 26.1 on Windows 10 > - (emacs-version) ; GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-05-29 > - (org-version) ; Org mode version 9.2.2 (9.2.2-13-g0007df-elpaplus @ /home/kai2nenobu/.emacs.d/elpa/org-plus-contrib-20190318/) > > - Emacs 26.1 on Ubuntu 18.04 on WSL (on above Windows 10) > - (emacs-version) ; GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-31 > - (org-version) ; Org mode version 9.2.1 (9.2.1-8-g1b1797-elpaplus @ c:/Users/kai2nenobu/.emacs.d/elpa/org-plus-contrib-20190211/) > > > I'm ready to contribute this patch, but I don't know how to contribute to "org-eldoc.el". Please tell me how to do it. > > > Best Regards, > > > 2018年2月4日(日) 16:56 Nicolas Goaziou <mail@nicolasgoaziou.fr>: > Hello, > > "numbchild@gmail.com" <numbchild@gmail.com> writes: > > > After some dive in deeper > > > > - [X] emacs minimal init test, confirmed issue in org-mode. > > - [X] from the error log, seems `org-eldoc` try to call `(progn (funcall > > mode-func) ...`. This caused `shell-mode()`. > > - [ ] check out `org-eldoc.el` source code, have not found any solution or > > options. > > > Hope some org-mode hacker can help to fix this issue? > > I'm Cc'ing Org Eldoc author about it. > > > And this might be a unit test in Org-mode testing? > > We don't test contrib packages. However, they can provide their own > tests. > > Regards, > > -- > Nicolas Goaziou > [-- Attachment #2: Message signed with OpenPGP --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: org-eldoc error on shell src blocks 2019-04-04 15:14 ` Takaaki Ishikawa @ 2019-04-07 7:18 ` Nicolas Goaziou 0 siblings, 0 replies; 6+ messages in thread From: Nicolas Goaziou @ 2019-04-07 7:18 UTC (permalink / raw) To: Takaaki Ishikawa Cc: Łukasz Gruner, 甲斐常伸, Org-mode Hello, Takaaki Ishikawa <takaxp@ieee.org> writes: > > I just verified the proposed patch to org-eldoc.el in contrib dir, works well. > But the problem is we lost an appropriate contact point because > https://bitbucket.org/ukaszg/org-eldoc was removed. > Who can amend org-eldoc.el in contribution directory? I applied a close patch. It "org-eldoc" is un-maintained, it would be nice if someone could take care of it and move it out of contrib. Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-07 7:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-02-02 1:32 org-eldoc error on shell src blocks numbchild 2018-02-04 7:42 ` numbchild 2018-02-04 7:55 ` Nicolas Goaziou 2019-03-31 8:53 ` 甲斐常伸 2019-04-04 15:14 ` Takaaki Ishikawa 2019-04-07 7:18 ` Nicolas Goaziou
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.