From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Konstantin Kharlamov <hi-angel@yandex.ru>
Cc: 35224@debbugs.gnu.org
Subject: bug#35224: [PATCH] include indentation size in .dir-locals
Date: Thu, 11 Apr 2019 16:22:54 +0100 [thread overview]
Message-ID: <87zhow36sx.fsf@tcd.ie> (raw)
In-Reply-To: <1554991004.18502.5@yandex.ru> (Konstantin Kharlamov's message of "Thu, 11 Apr 2019 16:56:44 +0300")
Konstantin Kharlamov <hi-angel@yandex.ru> writes:
> On Чт, Apr 11, 2019 at 11:58, Basil L. Contovounesios <contovob@tcd.ie> wrote:
>> Konstantin Kharlamov <hi-angel@yandex.ru> writes:
>>
>>> On Чт, Apr 11, 2019 at 11:26, Basil L. Contovounesios <contovob@tcd.ie>
>>> wrote:
>>>
>>>> Globally setting c-basic-offset overrides the cc-mode style inheritance
>>>> system. There are various ways to customise this variable in a more
>>>> granular way, such as defining a custom style which inherits from a
>>>> built-in style, or setting c-basic-offset locally in a mode hook.
>>>> For details, see (info "(ccmode) Config Basics").
>>>
>>> Oh, okay, so this works as expected. But since googling "change indentation
>>> size" always gives using specifically c-basic-offset (e.g.
>>> https://stackoverflow.com/questions/14939608/how-to-change-emacs-struct-indents-from-4-to-2-spaces),
>>> I guess it's safe to assume most of Emacs users has it changed. So it's
>>> useful
>>> to add this to dir-locals anyway.
>>
>> IMO, that's a bug in the configuration of those users because they're
>> overriding how cc-mode works, and the cc-mode manual describes in detail
>> the various ways to customise indentation. So I don't see a need to
>> change the Emacs dir-locals-file to accommodate this use-case.
>
> Okay, but we can't ignore the fact that such usecase exists and is widely
> employed (if needed, I can throw more links to these advices on stackexchange
> site).
The widespread dissemination of synoptic, not universally applicable, or
bad advise in the wild doesn't necessarily validate any particular
use-case.
> So let me ask: is there a downside to making this change? Because if there's
> none then the change is an improvement, it's that simple.
The downside is that this is an invasive change in that it affects all
people working on the Emacs sources. For many it may have no obvious
effect, for others it may mask problems/inconsistencies in their
configuration, and yet others it may end up annoying due to unforeseen
consequences. A net loss, potentially.
There is nothing obviously wrong with the current Emacs dir-locals-file
in this respect (if it ain't broke don't fix it), whereas the user
customisations you refer to are arguably problematic (if it is broke fix
it).
Again, just one opinion; I won't mind if others welcome this change.
--
Basil
prev parent reply other threads:[~2019-04-11 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 1:10 bug#35224: [PATCH] include indentation size in .dir-locals Konstantin Kharlamov
2019-04-11 2:16 ` Basil L. Contovounesios
2019-04-11 6:24 ` Konstantin Kharlamov
2019-04-11 10:26 ` Basil L. Contovounesios
2019-04-11 10:39 ` Konstantin Kharlamov
2019-04-11 10:58 ` Basil L. Contovounesios
2019-04-11 13:30 ` Eli Zaretskii
2019-06-23 17:42 ` Lars Ingebrigtsen
2019-04-11 13:56 ` Konstantin Kharlamov
2019-04-11 15:22 ` Basil L. Contovounesios [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhow36sx.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35224@debbugs.gnu.org \
--cc=hi-angel@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.