From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) Newsgroups: gmane.emacs.devel Subject: Re: Add support for base64url variant Date: Thu, 23 May 2019 21:37:01 +0200 Message-ID: <87zhnd55eq.fsf@killashandra.ballybran.fr> References: <87pnobiglo.fsf@killashandra.ballybran.fr> <83r28p57jp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="148929"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 23 21:37:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTtXB-000cbG-Bw for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 21:37:49 +0200 Original-Received: from localhost ([127.0.0.1]:42392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTtXA-0003Gd-DQ for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 15:37:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTtWX-0003GL-Fm for emacs-devel@gnu.org; Thu, 23 May 2019 15:37:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTtWW-0007za-LZ for emacs-devel@gnu.org; Thu, 23 May 2019 15:37:09 -0400 Original-Received: from smtp4-g21.free.fr ([212.27.42.4]:21722) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTtWR-0007w9-Fr; Thu, 23 May 2019 15:37:03 -0400 Original-Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e0a:1e2:f8b0:9cc3:35bf:aa81:ccf7]) by smtp4-g21.free.fr (Postfix) with ESMTPS id A684C19F58D; Thu, 23 May 2019 21:37:01 +0200 (CEST) In-Reply-To: <83r28p57jp.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 May 2019 21:50:50 +0300") X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 212.27.42.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236946 Archived-At: Eli Zaretskii writes: >> From: Pierre T=C3=A9choueyres >> Date: Wed, 22 May 2019 00:32:19 +0200 >>=20 >> + NILP(no_pad), !NILP(url_variant), > > Please leave one blank between the name of a macro or function and the > following opening parenthesis. Fixed. > >> + if (pad) { >> + *e++ =3D '=3D'; >> + *e++ =3D '=3D'; >> + } > > This is not our style of writing blocks in braces. We use this style: > > if (pad) > { > *e++ =3D '=3D'; > ... > >> + *e++ =3D b64_value_to_char[value]; >> + if (pad) { >> + *e++ =3D '=3D'; >> + } > > Likewise. > Fixed. > I'd suggest to call the new argument base64url or somesuch, since > this is trhe official name. > You mean in replacement of url_variant or b64_value_to_char ? How should I send new versions of the patch ? As a full patch in attachment like previously ?