bug#35376: 26.2; (emacs) `Xref Commands' - no mention of `mouse-1'

[Lars Ingebrigtsen <larsi@gnus.org>]

Drew Adams <drew.adams@oracle.com> writes:

> In bug #35353 Dmitry talks about a "show location bug don't switch
> windows" action.  Dunno what this is, so I went to the manual to find
> out.  Presumably, from the #35353 thread it has something to do with
> `mouse-1'.  And in any case `mouse-1' is the default way to access
> references using the mouse, no?  I would expect this node to say
> something about `mouse-1'.

The mouse bindings are a bit confusing:

(defvar xref--button-map
  (let ((map (make-sparse-keymap)))
    (define-key map [mouse-1] #'xref-goto-xref)
    (define-key map [mouse-2] #'xref--mouse-2)
    map))

Why is the command called xref--mouse-2?  That's a very non-descriptive
command name.  And...  don't these two really kinda do the same thing?
mouse-1 sets the point first and then goes to the xref, and mouse-2
... does the same, only in a different way?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no