From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33076: 26; `read-only-mode' messages Date: Wed, 10 Jul 2019 15:54:40 +0200 Message-ID: <87zhlm2dwf.fsf@mouse.gnus.org> References: <7d9a4a45-ac3d-4cff-a305-0e9e957b7609@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122603"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33076@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 10 15:55:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlD4A-000VmT-U6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 15:55:27 +0200 Original-Received: from localhost ([::1]:33194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlD49-00040Z-JO for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 09:55:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60119) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlD3n-0003zr-Vl for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 09:55:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlD3m-0007FG-Oh for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 09:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54548) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlD3m-0007Et-Fc for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 09:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlD3m-00029p-AZ for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 09:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33076 X-GNU-PR-Package: emacs Original-Received: via spool by 33076-submit@debbugs.gnu.org id=B33076.15627668878259 (code B ref 33076); Wed, 10 Jul 2019 13:55:02 +0000 Original-Received: (at 33076) by debbugs.gnu.org; 10 Jul 2019 13:54:47 +0000 Original-Received: from localhost ([127.0.0.1]:35132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlD3W-000299-TC for submit@debbugs.gnu.org; Wed, 10 Jul 2019 09:54:47 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:38416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlD3V-000290-Er for 33076@debbugs.gnu.org; Wed, 10 Jul 2019 09:54:46 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlD3R-0000rZ-FN; Wed, 10 Jul 2019 15:54:43 +0200 In-Reply-To: <7d9a4a45-ac3d-4cff-a305-0e9e957b7609@default> (Drew Adams's message of "Wed, 17 Oct 2018 10:04:00 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162634 Archived-At: Drew Adams writes: > It would be much clearer if the messages referred to the buffer by name, > rather than just "current buffer". You can use `C-x C-q' in the > selected window even when the buffer might not be clearly displayed > (e.g. tiny or partly obscured window/frame). Having the message tell > you which buffer you changed read-only for provides better confirmation. (and "in current buffer" should perhaps have a "the" in it anyway?) This is output by the define-minor-mode machinery: (if (called-interactively-p 'any) (progn ,(if (and globalp (not variable)) `(customize-mark-as-set ',mode)) ;; Avoid overwriting a message shown by the body, ;; but do overwrite previous messages. (unless (and (current-message) (not (equal ,last-message (current-message)))) (let ((local ,(if globalp "" " in current buffer"))) (message ,(format "%s %%sabled%%s" pretty-name) (if ,getter "en" "dis") local))))) So it looks easy enough to change, but it's a change that would affect all minor mode. Do we want all interactive minor modes to message the buffer names? I don't know what I think of it myself. Perhaps mainly because some buffer names are so long that this would increase the echo area sometimes, which is slightly annoying. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no