From: Lars Ingebrigtsen <larsi@gnus.org>
To: Ryan <rct@thompsonclan.org>
Cc: 27807@debbugs.gnu.org
Subject: bug#27807: 25.2; ido-completing-read handles cons-style initial-input wrong
Date: Mon, 15 Jul 2019 20:54:03 +0200 [thread overview]
Message-ID: <87zhlf86yc.fsf@mouse.gnus.org> (raw)
In-Reply-To: <f362a45d-5078-ab61-4fb8-0903768b86b9@thompsonclan.org> (Ryan's message of "Mon, 24 Jul 2017 11:50:06 -0700")
Ryan <rct@thompsonclan.org> writes:
>> `completing-read' uses 0-based index while `read-from-minibuffer' uses
>> 1-based index.
>
> Looking at "ido-read-internal", it passes the inital-input argument
> directly to "read-from-minibuffer" without incrementing it as
> "completing-read-default" does. Therefore any initial input of the form
> "(STRING . POSITION)" is handled incorrectly by ido, but this can be
> fixed by copying over the logic from "completing-read-default", as in
> this patch:
> https://mneme.dedyn.io/zerobin/?7cd07d73217c68e5#Aynth3YcZDcE7bkq8cxQnBl+uJ0/+d0UGYmB+7PqLT4=
The link is dead now, but I think I've now fixed this for Emacs 27.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-15 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 18:50 bug#27807: 25.2; ido-completing-read handles cons-style initial-input wrong Ryan
2019-07-15 18:54 ` Lars Ingebrigtsen [this message]
2019-07-15 19:24 ` Ryan C. Thompson
2019-07-16 3:37 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhlf86yc.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=27807@debbugs.gnu.org \
--cc=rct@thompsonclan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.