From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Julien Danjou <julien@danjou.info>, emacs-devel@gnu.org
Subject: Re: [PATCH] Improve Gravatar support
Date: Mon, 22 Jul 2019 22:44:53 +0100 [thread overview]
Message-ID: <87zhl54ucq.fsf@tcd.ie> (raw)
In-Reply-To: <8736iy2o2i.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Mon, 22 Jul 2019 15:31:17 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> After skimming (on holiday), looks good to me.
Thanks, enjoy your holiday! There's no rush on my part.
> Extremely minor comments below:
>
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> (defcustom gnus-gravatar-too-ugly gnus-article-x-face-too-ugly
>> - "Regexp matching posters whose avatar shouldn't be shown automatically."
>> - :type '(choice regexp (const nil))
>> + "Regexp matching posters whose avatar shouldn't be shown automatically.
>> +Nil means show all avatars."
>
> We don't capitalise nil in documentation, do we?
"git grep '\<Nil\>'" returns only a few hits, so I guess you're right.
Will change.
>> - ;; The buffer can be gone at this time
>> - (when (buffer-live-p (current-buffer))
>> + ;; The buffer can be gone at this time.
>> + (when (buffer-name)
>
> I think buffer-live-p is clearer than just saying buffer-name.
Agreed.
>> - (interactive (list t)) ;; When type `W D g'
>> + (interactive "p") ;; When type `W D g'
>
> Perhaps grammer fix?
I'd rather remove these comments altogether, if that's okay with you.
The default key bindings are not important here, and it's tautological
to say that the interactive spec takes effect when the function is
called as the result of a key binding.
These changes are now included in the split patch set in my other
message.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-07-22 21:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 13:23 [PATCH] Improve Gravatar support Basil L. Contovounesios
2019-07-22 13:31 ` Lars Ingebrigtsen
2019-07-22 21:44 ` Basil L. Contovounesios [this message]
2019-07-23 11:29 ` Lars Ingebrigtsen
2019-07-22 13:39 ` Andy Moreton
2019-07-22 21:42 ` Basil L. Contovounesios
2019-07-23 2:31 ` Eli Zaretskii
2019-07-23 8:36 ` Basil L. Contovounesios
2019-07-23 8:36 ` Andy Moreton
2019-07-23 9:18 ` Basil L. Contovounesios
2019-08-02 13:45 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhl54ucq.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=julien@danjou.info \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.