From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Date: Sun, 25 Aug 2019 07:24:39 +0200 Message-ID: <87zhjxakbs.fsf@gnus.org> References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> <87mug2xoek.fsf@mouse.gnus.org> <2f9b873f-3ac0-0008-0c23-1add5eb82a03@gmx.at> <8736hsd9qm.fsf@mouse.gnus.org> <70aa4943-eb2d-ffa2-b6ee-4638181d1920@gmx.at> <87a7c0cnn2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193857"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Christoph Scholtes , 9867@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 07:25:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1l1c-000oJh-83 for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 07:25:12 +0200 Original-Received: from localhost ([::1]:40858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1l1b-0000X5-5A for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 01:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51346) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1l1T-0000Wy-7W for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:25:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1l1S-00038n-4r for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34623) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1l1S-00038P-0x for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1l1R-0005e3-Q1 for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 05:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156671068821671 (code B ref 9867); Sun, 25 Aug 2019 05:25:01 +0000 Original-Received: (at 9867) by debbugs.gnu.org; 25 Aug 2019 05:24:48 +0000 Original-Received: from localhost ([127.0.0.1]:43444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1l1E-0005dR-Fl for submit@debbugs.gnu.org; Sun, 25 Aug 2019 01:24:48 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:57476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1l1C-0005dI-G8 for 9867@debbugs.gnu.org; Sun, 25 Aug 2019 01:24:47 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1l16-0001Nj-25; Sun, 25 Aug 2019 07:24:42 +0200 In-Reply-To: (martin rudalics's message of "Fri, 23 Aug 2019 10:42:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165797 Archived-At: martin rudalics writes: >> That's true, but is there a use case for the hook function having to >> know what window it's quitting? > > I don't know. But you could replace 'with-current-buffer' with > 'with-selected-window' to avoid worrying about that (and better check > if WINDOW is not already selected before doing that internal state > saving rigmarole). I wasn't aware of `with-selected-window' -- it sounds a bit dramatic. Does it have any side effects? > Or, as I suggested earlier, run the hook only when > quitting the selected window. That's possible, but the semantics become perhaps a bit complicated? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no