From: Lars Ingebrigtsen <larsi@gnus.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Christoph Scholtes <cschol2112@googlemail.com>, 9867@debbugs.gnu.org
Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook
Date: Sun, 25 Aug 2019 07:24:39 +0200 [thread overview]
Message-ID: <87zhjxakbs.fsf@gnus.org> (raw)
In-Reply-To: <ddc46ca9-abcf-0a7d-9f29-573f6a7cac56@gmx.at> (martin rudalics's message of "Fri, 23 Aug 2019 10:42:32 +0200")
martin rudalics <rudalics@gmx.at> writes:
>> That's true, but is there a use case for the hook function having to
>> know what window it's quitting?
>
> I don't know. But you could replace 'with-current-buffer' with
> 'with-selected-window' to avoid worrying about that (and better check
> if WINDOW is not already selected before doing that internal state
> saving rigmarole).
I wasn't aware of `with-selected-window' -- it sounds a bit dramatic.
Does it have any side effects?
> Or, as I suggested earlier, run the hook only when
> quitting the selected window.
That's possible, but the semantics become perhaps a bit complicated?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-25 5:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 4:04 bug#9867: 24.0.90; quit-window should provide quit-window-hook Christoph Scholtes
2019-08-20 2:22 ` Lars Ingebrigtsen
2019-08-20 8:19 ` martin rudalics
2019-08-20 14:25 ` Eli Zaretskii
2019-08-21 20:23 ` Lars Ingebrigtsen
2019-08-21 20:18 ` Lars Ingebrigtsen
2019-08-22 8:08 ` martin rudalics
2019-08-23 0:08 ` Lars Ingebrigtsen
2019-08-23 7:46 ` martin rudalics
2019-08-23 8:05 ` Lars Ingebrigtsen
2019-08-23 8:42 ` martin rudalics
2019-08-25 5:24 ` Lars Ingebrigtsen [this message]
2019-08-25 8:11 ` martin rudalics
2019-08-30 9:40 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhjxakbs.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=9867@debbugs.gnu.org \
--cc=cschol2112@googlemail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.