From: Johan Claesson <johanclaesson@bredband.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 37174@debbugs.gnu.org
Subject: bug#37174: 26.2; Stabilize tabulated-list reversed sort
Date: Sun, 22 Sep 2019 11:26:37 +0200 [thread overview]
Message-ID: <87zhiwy94i.fsf@bredband.net> (raw)
In-Reply-To: <871rxaiqpz.fsf@bredband.net>
Hi Lars,
I am willing to sign myself but the company i work for also need to sign
and the last time i asked they refused. If this will become a problem
in the future i might ask them again.
Regards,
/Johan
On Sat, Sep 21 2019, Lars Ingebrigtsen wrote:
> Johan Claesson <johanclaesson@bredband.net> writes:
>
>> Sorting with S multiple times in a tabulated-list buffer should be
>> stable but will sometimes reorder entries with the same value. When the
>> sort order is reversed the function tabulated-list--get-sorter will
>> transform the sort function to sort the other way around by negating. I
>> think this is what cause the needless reordering and that it should be
>> changed something like the following:
>
> [...]
>
>> (if (cdr tabulated-list-sort-key)
>> - (lambda (a b) (not (funcall sorter a b)))
>> + (lambda (a b) (funcall sorter b a))
>
> That looks like the correct solution, so I've applied it to the trunk.
>
> If I read the logs correctly, I think that cumulatively you've now had
> the number of lines committed to Emacs that's allowed without signing
> copyright assignment papers. For future patches, would you be willing
> to sign such paperwork?
prev parent reply other threads:[~2019-09-22 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 14:27 bug#37174: 26.2; Stabilize tabulated-list reversed sort Johan Claesson
2019-09-20 22:09 ` Lars Ingebrigtsen
2019-09-22 9:26 ` Johan Claesson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhiwy94i.fsf@bredband.net \
--to=johanclaesson@bredband.net \
--cc=37174@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.