From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37420: [PATCH] Recommend against SHA-1 for security-related applications Date: Sat, 28 Sep 2019 21:55:12 +0200 Message-ID: <87zhiotcv3.fsf@gnus.org> References: <87v9tsv65b.fsf@gnus.org> <87ef0grneg.fsf@gnus.org> <83muf3wj8q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="138975"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Robert Pluim , 37420@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 28 21:56:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEIpR-000a4M-IP for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 21:56:29 +0200 Original-Received: from localhost ([::1]:34766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEIpQ-00025u-DV for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 15:56:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50234) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEIp3-00025b-2X for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 15:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEIp2-0001BS-2G for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 15:56:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEIp0-0001Ar-HO for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 15:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEIp0-0006SS-FU for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 15:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Sep 2019 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37420-submit@debbugs.gnu.org id=B37420.156970051824766 (code B ref 37420); Sat, 28 Sep 2019 19:56:02 +0000 Original-Received: (at 37420) by debbugs.gnu.org; 28 Sep 2019 19:55:18 +0000 Original-Received: from localhost ([127.0.0.1]:51319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEIoI-0006RO-9E for submit@debbugs.gnu.org; Sat, 28 Sep 2019 15:55:18 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:35684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEIoF-0006RE-Ta for 37420@debbugs.gnu.org; Sat, 28 Sep 2019 15:55:17 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEIoC-0006Nt-AM; Sat, 28 Sep 2019 21:55:14 +0200 In-Reply-To: (Stefan Kangas's message of "Sat, 28 Sep 2019 12:19:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167527 Archived-At: Stefan Kangas writes: > Thanks Eli and Robert. How about the attached patch? Looks good to me, but one tiny thing: > +(ert-deftest test-secure-hash () > + (should (equal (secure-hash 'md5 "foobar") "3858f62230ac3c915f300c664312c63f")) > + (should (equal (secure-hash 'sha1 "foobar") "8843d7f92416211de9ebb963ff4ce28125932878")) > + (should (equal (secure-hash 'sha224 "foobar") (concat "de76c3e567fca9d246f5f8d3b2e704a3" > + "8c3c5e258988ab525f94 Perhaps the lines should be folded to avoid too-long lines? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no