From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Tab bar tabs landed on master Date: Wed, 02 Oct 2019 19:27:47 +0300 Organization: LINKOV.NET Message-ID: <87zhijqfys.fsf@mail.linkov.net> References: <8736gci5jn.fsf@mail.linkov.net> <83muej8a0f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="152503"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Juanma Barranquero , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 02 18:32:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFhXu-000dSy-Jg for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 18:32:11 +0200 Original-Received: from localhost ([::1]:57586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFhXs-0006Qj-Qq for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 12:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60468) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFhXZ-0006Q6-Bb for emacs-devel@gnu.org; Wed, 02 Oct 2019 12:31:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFhXY-00029q-38 for emacs-devel@gnu.org; Wed, 02 Oct 2019 12:31:49 -0400 Original-Received: from buffalo.birch.relay.mailchannels.net ([23.83.209.24]:14304) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFhXW-00028t-5Z; Wed, 02 Oct 2019 12:31:46 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 3C27D22FCB; Wed, 2 Oct 2019 16:31:44 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (100-96-29-174.trex.outbound.svc.cluster.local [100.96.29.174]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BBC0123013; Wed, 2 Oct 2019 16:31:43 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.2); Wed, 02 Oct 2019 16:31:44 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thread-Average: 4f6a19241cb06a96_1570033904007_3803979722 X-MC-Loop-Signature: 1570033904007:2551812843 X-MC-Ingress-Time: 1570033904007 Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 654A685003; Wed, 2 Oct 2019 09:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=tbzFXcNUWWPwYPGndnYAqIY1KFs=; b= EdhpzzNd6c7uTFlhqSI+DEtDsfg02SFeP1a9qQFa7orhdXvAZM3+XUEKsq9oORuJ uu4kQ1vD2igox6bba2IdsOI7orvOAkdK7vfrg6/IMe6obMrX+KR/ptZoZAvBPvNA lQk2JI4D7gQ37ZMgHr6/rOQSlvt3WMtG5KfIQ00Xa1k= Original-Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 5A94085016; Wed, 2 Oct 2019 09:31:35 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a3 In-Reply-To: <83muej8a0f.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Oct 2019 18:03:44 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrgeeigddutdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrleelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleelrdelledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.209.24 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240474 Archived-At: >> Enabling tab-bar-mode grows the frame's height (not always, just the >> first time). Disabling the mode does not shrink it. Is that intended? > > What's worse, this also happens in the -nw session on MS-Windows, and > that makes the session all but unusable, because the echo-area is > mostly invisible, and the mouse clicks don't work, probably because of > the same miscalculation of coordinates. Tab-bar code is just a copy of tool-bar code. And indeed running `emacs -Q -f tool-bar-mode' that disables tool-bar-mode exposes the same problem: (let ((initial (assq 'outer-size (frame-geometry)))) (tool-bar-mode 1) (tool-bar-mode 0) (list (assq 'outer-size (frame-geometry)) initial)) => ((outer-size 680 . 693) (outer-size 680 . 676)) The reason why this problem was unknown until now is because tool-bar-mode is enabled by default. But disabling it with a command line option of by using .Xresources causes frame resizing. So we need to fix it simultaneously for both tool-bar and tab-bar. I'd appreciate any help from our experts in window-related code.