From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37771: 26.3; doc for `dired-auto-revert-buffer' Date: Thu, 17 Oct 2019 04:57:46 +0200 Message-ID: <87zhi0krit.fsf@gnus.org> References: <60cfbdb5-8f92-4af6-bf5a-f1f7f05bd1c6@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149692"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37771@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 17 04:58:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKvzO-000cpQ-Pg for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 04:58:10 +0200 Original-Received: from localhost ([::1]:58056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKvzN-0007Ia-MV for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 22:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60678) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKvzH-0007Hu-Fk for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 22:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKvzG-0001Ku-7y for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 22:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38052) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKvzG-0001Ko-4i for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 22:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKvzG-0007bS-0u for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 22:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2019 02:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37771 X-GNU-PR-Package: emacs Original-Received: via spool by 37771-submit@debbugs.gnu.org id=B37771.157128107529196 (code B ref 37771); Thu, 17 Oct 2019 02:58:01 +0000 Original-Received: (at 37771) by debbugs.gnu.org; 17 Oct 2019 02:57:55 +0000 Original-Received: from localhost ([127.0.0.1]:46870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKvz5-0007ak-SD for submit@debbugs.gnu.org; Wed, 16 Oct 2019 22:57:55 -0400 Original-Received: from [80.91.231.51] (port=43434 helo=quimby.gnus.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKvz4-0007ac-Oz for 37771@debbugs.gnu.org; Wed, 16 Oct 2019 22:57:51 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKvz0-0004SM-EU; Thu, 17 Oct 2019 04:57:48 +0200 In-Reply-To: <60cfbdb5-8f92-4af6-bf5a-f1f7f05bd1c6@default> (Drew Adams's message of "Tue, 15 Oct 2019 15:35:05 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169519 Archived-At: Drew Adams writes: > Please consider improving the doc so that it does the following: > > * Explains what is meant by "visiting" a Dired buffer. The Emacs > manuals and other doc only speak about visiting a file in a buffer. > Just what constitutes "visiting" a Dired buffer? It seems like it's > sufficient to display the buffer and select its window. Is that it? It means whatever Emacs means by "visiting" a file. I don't see what's there to explain. > * Explains the Value Menu items in Customize - in particular, item > `Revert changed Dired buffer'. Explaining what "revert" means in this context seems a bit odd. There's a manual for that. > * Explains that the option has no effect on Dired buffers containing > arbitrary file lists (i.e., whose DIRNAME is a cons). It is relevant > only for actual directory listings. You mean that switching it off doesn't stop reverting in that case? ;; Always revert when `dir-or-list' is a cons. Also revert ;; if `dired-directory' is a cons but `dir-or-list' is not. ((or (consp dir-or-list) (consp dired-directory)) (setq dired-directory dir-or-list) (revert-buffer)) ;; Always revert regardless of whether it has changed or not. ((eq dired-auto-revert-buffer t) (revert-buffer)) As far as I can tell, this is only reached when you call `dired' explicitly with a list of file names? That dired updates the buffer when you call it with a bunch of file names, without consulting dired-auto-revert-buffer, seems pretty self-evident. > * Lists the Lisp values that correspond to the Value Menu items. They all seem documented? (const :tag "Revert changed Dired buffer" dired-directory-changed-p) is just a predicate function. Didn't see anything that needed fixing here, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no