From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread Date: Mon, 18 Nov 2019 12:38:03 -0800 Message-ID: <87zhgsncno.fsf@ericabrahamsen.net> References: <87imnu1knq.fsf@dick> <87r22h7mka.fsf@ericabrahamsen.net> <87sgmrouxk.fsf@gnus.org> <8736emaxw6.fsf@ericabrahamsen.net> <87sgmlsgxx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="41928"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: dick.r.chiang@gmail.com, 38136@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 18 21:39:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWnnv-000AnC-2g for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Nov 2019 21:39:23 +0100 Original-Received: from localhost ([::1]:39162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWnnt-0005s2-MF for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Nov 2019 15:39:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57977) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWnnm-0005rE-Rx for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2019 15:39:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWnnf-0003va-St for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2019 15:39:13 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37505) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWnnf-0003ty-PO for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2019 15:39:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWnnZ-0003UQ-Iq; Mon, 18 Nov 2019 15:39:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87imnu1knq.fsf@dick> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Mon, 18 Nov 2019 20:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38136 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 38136-submit@debbugs.gnu.org id=B38136.157410949813357 (code B ref 38136); Mon, 18 Nov 2019 20:39:01 +0000 Original-Received: (at 38136) by debbugs.gnu.org; 18 Nov 2019 20:38:18 +0000 Original-Received: from localhost ([127.0.0.1]:46326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWnmr-0003TN-SH for submit@debbugs.gnu.org; Mon, 18 Nov 2019 15:38:18 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:43086 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWnmq-0003TA-93 for 38136@debbugs.gnu.org; Mon, 18 Nov 2019 15:38:16 -0500 Original-Received: from localhost (unknown [205.175.106.77]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 00D56FA087; Mon, 18 Nov 2019 20:38:09 +0000 (UTC) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171936 Archived-At: On 11/18/19 09:54 AM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> I haven't tried to make it raise an error, but I did set >> `nntp-connection-timeout' very low, and try to trigger an error that >> way. Nothing bad happened -- I will take a look at the code and see how >> timeouts are handled. > > Try putting an (error) in `nntp-open-server' or something. :-) Oh, sure. I stuck errors in `nntp-open-server' and `nntp-finish-retrieve-group-infos', and worked that both with a nntp-connection-timeout and without, and wasn't able to drive it completely off the rails -- unfortunately I did get two odd errors which I was later unable to reproduce: one about selecting a deleted buffer, which I think came out of `nntp-open-server', and another that looked like "gnus-thread-group: " and then a chunk of bytecode. I don't know how I got those, though! The only other error I'm seeing now is if you start Gnus at a specified level (ie "M-4 M-x gnus"), it will error out in `gnus-get-unread-articles', line 1791, because it's expecting "(car gnus-group-list-mode)" to be a number, but it hasn't been set yet. In general, it would be great to have more code comments, particularly in `gnus-get-unread-articles'. I'm afraid that we're going to end up with more code that only one person really understands, touching on an area of elisp (threading) that we're all kind of expecting to be unstable. That's all I've got for now.