From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method Date: Thu, 05 Dec 2019 12:21:06 +0100 Message-ID: <87zhg7f271.fsf@marxist.se> References: <20191028112645.GA18613@breton.holly.idiocy.org> <20191029192045.GA57404@breton.holly.idiocy.org> <20191031205346.GA5518@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="199432"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: HaiJun Zhang , "23412-done@debbugs.gnu.org" <23412@debbugs.gnu.org> To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 05 12:22:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icpD2-000ph9-5C for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 12:22:12 +0100 Original-Received: from localhost ([::1]:53206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icpD0-0005ne-Vw for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 06:22:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37010) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icpCu-0005jD-Dn for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 06:22:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icpCt-00046a-0u for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 06:22:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37179) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icpCs-00045L-Ph for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 06:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1icpCs-0005Nm-KS for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 06:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2019 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23412 X-GNU-PR-Package: emacs Original-Received: via spool by 23412-submit@debbugs.gnu.org id=B23412.157554487520617 (code B ref 23412); Thu, 05 Dec 2019 11:22:02 +0000 Original-Received: (at 23412) by debbugs.gnu.org; 5 Dec 2019 11:21:15 +0000 Original-Received: from localhost ([127.0.0.1]:43152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icpC7-0005MT-Fa for submit@debbugs.gnu.org; Thu, 05 Dec 2019 06:21:15 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:45180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icpC5-0005ME-Sg for 23412@debbugs.gnu.org; Thu, 05 Dec 2019 06:21:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sgpgYYSQoyBdP8nH0z2VoSEcEIEIhUDkL3hAojb9+24=; b=tt9bwreJr8CwWIJM93V4NVwjzF 8msQj/qOByRyaFPGxdMPQUbzKhS3Tl9hS9uqmXditDhB5JAsjlpvClHSy0U+jyApdNz/2VyOFT9aW q3iAIC7yusrTU+aawr3KAQGehvyj2wcVcOH38ezyzP3KS54tzOyG939tD4RbkX8V2hiU1eytdyGUE yRK0gbBfHhs7qGcE+DHfbdD6dKjQAuOIgXQ2Al5sIzr31dxPdIG07C5uIyK80hC2QLuINlOzIgtsM C8SOaOeeHc9IkYtv1Es5q4oHt/VLv1TS4+boBr9gz/+aD/yi6filRpAMJ3Hl33l4BFffAusbh7JOu tM4E1Szw==; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:45326 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1icpC0-001I8T-0v; Thu, 05 Dec 2019 06:21:08 -0500 In-Reply-To: <20191031205346.GA5518@breton.holly.idiocy.org> (Alan Third's message of "Thu, 31 Oct 2019 20:53:46 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172895 Archived-At: Alan Third writes: > On Wed, Oct 30, 2019 at 01:15:04AM +0000, HaiJun Zhang wrote: >> =E5=9C=A8 2019=E5=B9=B410=E6=9C=8830=E6=97=A5 +0800 AM3:20=EF=BC=8CAlan = Third =EF=BC=8C=E5=86=99=E9=81=93=EF=BC=9A >> >=20 >> > I think in C we can get away with just checking whether the new text >> > is empty. If there is any text at all then replacing the working text >> > seems to do the right thing, even if the new text is shorter than the >> > old. I could be wrong, though, I=E2=80=99ve never really used these in= put >> > methods so don=E2=80=99t know if there are things I=E2=80=99m not test= ing. >> >=20 >> > New patch attached, please try it and let me know how it goes. >> >> It works perfectly now. Thanks. > > Thank you for finding the root cause! I=E2=80=99ve pushed the change to > master, so it should be available in Emacs 27 now. That was five weeks ago. If the issue has been fixed, should we also go ahead and close this bug report? Best regards, Stefan Kangas