From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Newsgroups: gmane.emacs.bugs Subject: bug#39842: [PATCH] Use help-fns-short-filename in other describe- commands Date: Sat, 29 Feb 2020 21:18:33 +0100 Message-ID: <87zhd187vq.fsf@gmail.com> References: <20200229190008.338460-1-stepnem@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="79419"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 39842@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 29 21:19:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j88Zr-000KXk-PX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Feb 2020 21:19:11 +0100 Original-Received: from localhost ([::1]:35560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j88Zq-0004w6-IK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Feb 2020 15:19:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48522) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j88Zj-0004vk-8g for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:19:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j88Zi-00016q-Cc for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:19:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j88Zi-00016j-9a for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j88Zi-0006Xg-5a for bug-gnu-emacs@gnu.org; Sat, 29 Feb 2020 15:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Feb 2020 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39842 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39842-submit@debbugs.gnu.org id=B39842.158300751025101 (code B ref 39842); Sat, 29 Feb 2020 20:19:02 +0000 Original-Received: (at 39842) by debbugs.gnu.org; 29 Feb 2020 20:18:30 +0000 Original-Received: from localhost ([127.0.0.1]:35450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j88ZC-0006Wn-K4 for submit@debbugs.gnu.org; Sat, 29 Feb 2020 15:18:30 -0500 Original-Received: from mail-lf1-f68.google.com ([209.85.167.68]:41250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j88Z9-0006WX-J2 for 39842@debbugs.gnu.org; Sat, 29 Feb 2020 15:18:28 -0500 Original-Received: by mail-lf1-f68.google.com with SMTP id y17so4651842lfe.8 for <39842@debbugs.gnu.org>; Sat, 29 Feb 2020 12:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=H/vkV9svvOMQ5FhpE27n2Bxhrjjd5nbtuuQSuhnaKMg=; b=OcFfjXRFFd0iyzBlF51QRvlVRbx6Fh+lNtZvJU29AM524FfTyqyJRA7FG7EIYtJF19 NeVPgXtzk/yMrmrOi094M+bODPx7bhlYGjJcbKaie3A5j653fvrur+EvI8myAWoUtSuk GJMjMh5EoM33Pia1pA+eJNEkjJK1jHKTKkkWVTm4ulVTfPql8D/bNLdDJ27cQzN1Co9p y424drgivEtMTwWjpIhOYbhApbmx8eWeGnA1e2Lxfbmw7MPwhqGbf8ZbaXRC9RH7LH0z yI6XStYwu5TvjoF0noJ+A8tg0Piy9r/iAI5uJhoxiKHMj1yHmy5N9KLWohgLLaYm7t0g IerQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=H/vkV9svvOMQ5FhpE27n2Bxhrjjd5nbtuuQSuhnaKMg=; b=NJg+Eb3cl9SIxzEhDg8aVjmTw7QkXdLpnmNmKOFF8RJZ/13dbsptv16ee3EzT9HR7D uHLXkbH+kr9kbWwDSBV+9AsNLAQQvmN4Y4QfS1InQks1yf1kZb7Via1S9oDJUpFc6CZO xq3Q1QvLUeVlEXYjljRhKEek/M2EqeeGv9HDCMrjb7gz1cl69EhDiOo7JJZSRMmsmM35 5+Ydhkzynm4LEsXlNRvBnGlZW/+zBwEv/gT1JXsyQt2xVGk7oYvyKpaNiz1xBgeskwhG E2pPQwXVqCxRhrKWGXt+VdASvbEDR/Q5JqPqBrBrVCUiq8/nwRIPyIgNztd4nXJ+cc/5 9a5Q== X-Gm-Message-State: ANhLgQ0Z4N4HGoeAvoRYXuYYFuQxuQPrV11GgEVrRb+5jAZUbnSnzjGS sf7HU/qm2ueka4RYkAq+sYDl6EX5 X-Google-Smtp-Source: ADFU+vvfSfYdv8CYFXHvzGHAikbEwgPB1uX7f3WMWAVD/QG35LkkKqx8IkNXIWG5bj/1gzgYbMIBIg== X-Received: by 2002:a19:4c86:: with SMTP id z128mr6034026lfa.100.1583007501492; Sat, 29 Feb 2020 12:18:21 -0800 (PST) Original-Received: from localhost ([185.112.167.59]) by smtp.gmail.com with ESMTPSA id s21sm8881177lfb.27.2020.02.29.12.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Feb 2020 12:18:20 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176693 Archived-At: On Sat, 29 Feb 2020 15:02:05 -0500 Stefan Monnier wrote: >> +;;;###autoload >> (defun help-fns-short-filename (filename) > > OK, we can live that. Maybe, moving it to help.el would be a cleaner opt= ion. > >> index 45cbaad4e8..32204d04e3 100644 >> --- a/lisp/help.el >> +++ b/lisp/help.el >> @@ -879,6 +879,7 @@ describe-key >> (princ ", which is ") >> (describe-function-1 defn))))))) >> >> +(declare-function help-fns-short-filename "help-fns" (filename)) >> (defun describe-mode (&optional buffer) >> "Display documentation of current major mode and minor modes. >> A brief summary of the minor modes comes first, followed by the > > The autoload cookie above should render this `declare-function` > unnecessary, right? R...right...? I'm somewhat unclear on the "something non-preloaded required by something preloaded" situation. :-) So, which shall it be? Move help-fns-short-filename to help.el, or just remove the declaration? Thanks, =C5=A0t=C4=9Bp=C3=A1n