From: Juri Linkov <juri@linkov.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 39902@debbugs.gnu.org
Subject: bug#39902: 28.0.50; Marking in dired with active region
Date: Wed, 11 Mar 2020 02:18:22 +0200 [thread overview]
Message-ID: <87zhcn9229.fsf@mail.linkov.net> (raw)
In-Reply-To: <87eetzah2s.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 11 Mar 2020 02:08:43 +0200")
>> OTOH, if point is at the end of the region (in contrast to your
>> screenshot), one could be surprised that the file line where the cursor
>> is displayed doesn't get marked.
>
> Right, here is a complete patch that should do the right thing
> depending on the new defcustom:
Sorry, this patch was a response to another your comment:
>> This is a strange corner case. I never used a region like that, I guess
>> because I felt that this case is dubious.
This means that the patch doesn't handle this strange corner case,
but it handles more usual case where point is on the file name:
diff --git a/lisp/dired.el b/lisp/dired.el
index a4de51f609..420938ef2e 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -3578,6 +3578,12 @@ dired-mark-files-in-region
(insert dired-marker-char)))
(forward-line 1))))
+(defcustom dired-mark-inclusive nil
+ "Non-nil means `dired-mark' marks file on the region end."
+ :type 'boolean
+ :version "28.1"
+ :group 'dired)
+
(defun dired-mark (arg &optional interactive)
"Mark the file at point in the Dired buffer.
If the region is active, mark all files in the region.
@@ -3597,7 +3603,11 @@ dired-mark
(end (region-end)))
(dired-mark-files-in-region
(progn (goto-char beg) (line-beginning-position))
- (progn (goto-char end) (line-beginning-position))))))
+ (progn (goto-char end)
+ (if (and dired-mark-inclusive
+ (or (eolp) (get-text-property (point) 'dired-filename)))
+ (line-end-position)
+ (line-beginning-position)))))))
;; Mark subdir files from the subdir headerline.
((dired-get-subdir)
(save-excursion (dired-mark-subdir-files)))
next prev parent reply other threads:[~2020-03-11 0:18 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 14:29 bug#39902: 28.0.50; Marking in dired with active region Michael Heerdegen
2020-03-04 15:41 ` Drew Adams
2020-03-04 16:04 ` Stephen Berman
2020-03-04 21:07 ` Drew Adams
2020-03-04 23:46 ` Juri Linkov
2020-03-05 1:11 ` Drew Adams
2020-03-05 13:58 ` Michael Heerdegen
2020-03-05 23:42 ` Juri Linkov
2020-03-06 2:30 ` Drew Adams
2020-03-07 0:07 ` Michael Heerdegen
2020-03-08 0:38 ` Juri Linkov
2020-03-08 14:00 ` Michael Heerdegen
2020-03-08 17:04 ` Drew Adams
2020-03-08 23:56 ` Juri Linkov
2020-03-09 0:37 ` Drew Adams
2020-03-09 14:53 ` Michael Heerdegen
2020-03-09 22:28 ` Juri Linkov
2020-03-10 0:41 ` Drew Adams
2020-03-10 23:24 ` Juri Linkov
2020-03-10 23:49 ` Stephen Berman
2020-03-10 23:56 ` Juri Linkov
2020-03-11 0:24 ` Drew Adams
2020-03-10 23:55 ` Michael Heerdegen
2020-03-11 0:08 ` Juri Linkov
2020-03-11 0:18 ` Juri Linkov [this message]
2020-03-11 0:29 ` Drew Adams
2020-03-11 1:21 ` Michael Heerdegen
2020-03-12 0:43 ` Juri Linkov
2020-03-12 1:13 ` Drew Adams
2020-03-13 0:39 ` Juri Linkov
2020-03-13 8:31 ` Pieter van Oostrum
2020-03-13 22:30 ` Michael Heerdegen
2020-03-14 18:03 ` Drew Adams
2020-03-14 17:56 ` Drew Adams
2020-03-14 23:45 ` Juri Linkov
2020-03-15 2:46 ` Michael Heerdegen
2020-03-15 20:52 ` Drew Adams
2020-03-15 20:50 ` Drew Adams
2020-03-15 23:41 ` Juri Linkov
2020-03-16 1:46 ` Drew Adams
2020-03-17 0:51 ` Michael Heerdegen
2020-03-18 23:51 ` Juri Linkov
2020-03-19 23:54 ` Juri Linkov
2020-03-22 2:48 ` Michael Heerdegen
2020-03-22 23:33 ` Drew Adams
2020-03-23 0:43 ` Juri Linkov
2020-03-23 15:09 ` Drew Adams
2020-03-24 21:58 ` Juri Linkov
2020-03-24 22:14 ` Drew Adams
2020-03-23 0:35 ` Juri Linkov
2020-03-23 15:20 ` Drew Adams
2020-03-24 21:58 ` Juri Linkov
2020-03-24 22:13 ` Drew Adams
2020-03-16 15:21 ` Drew Adams
2020-03-09 14:52 ` Michael Heerdegen
2020-03-09 14:50 ` Michael Heerdegen
2020-03-09 15:22 ` Drew Adams
2020-03-10 16:04 ` Michael Heerdegen
2020-03-10 16:33 ` Drew Adams
2020-03-09 9:04 ` martin rudalics
2020-03-09 15:02 ` Michael Heerdegen
2020-03-09 15:39 ` Drew Adams
2020-03-10 16:08 ` Michael Heerdegen
2020-03-09 17:12 ` martin rudalics
2020-03-10 15:52 ` Michael Heerdegen
-- strict thread matches above, loose matches on Subject: below --
2020-05-08 8:26 Making Emacs popular again with a video Nathan Colinet
2020-05-10 20:57 ` Nathan Colinet
2020-05-12 3:12 ` Richard Stallman
2020-05-12 12:57 ` GNU Emacs raison d'etre excalamus--- via Emacs development discussions.
2020-05-13 16:18 ` Karl Fogel
2020-05-13 19:39 ` Andreas Röhler
2020-05-13 20:05 ` Karl Fogel
2020-05-13 20:52 ` Dmitry Gutov
2020-05-13 22:04 ` Karl Fogel
2020-05-13 22:55 ` Dmitry Gutov
2020-05-14 4:56 ` Karl Fogel
2020-05-17 1:28 ` Dmitry Gutov
2020-05-17 1:59 ` Jean-Christophe Helary
2020-05-18 3:43 ` transient Richard Stallman
2020-05-18 6:58 ` transient Joost Kremers
2020-05-18 18:41 ` transient Howard Melman
2020-05-19 5:38 ` transient Drew Adams
2020-05-19 14:00 ` transient Arthur Miller
2020-05-20 3:14 ` transient Michael Heerdegen
[not found] ` <87tuztngxr.fsf@mail.linkov.net>
2020-06-03 4:32 ` bug#39902: transient Michael Heerdegen
2020-06-03 22:49 ` bug#39902: 28.0.50; Marking in dired with active region Juri Linkov
2020-06-04 12:31 ` Michael Heerdegen
2020-06-04 22:18 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhcn9229.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=39902@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.