Re: Patch for a simple nil check in `calc-graph-add-curve'

["Bruno Félix Rezende Ribeiro" <oitofelix@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Hello,

FWIW, this has /not/ been integrated into master yet.

Narendra Joshi <narendraj9@gmail.com> writes:

> A simple `calc-graph-fast' call with the following values on Emacs
> Calc stack fails:
> 3:  [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
> 2:  [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
> 1:  [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
> <top of the stack>
> It fails because `calc-graph-fast` eventually calls `math-trunc` on
> the line and point style values which aren't set yet. Since they are
> `nil` we should avoid calling `math-trunc` on them and take a default
> value. The patch just adds a `nil` check for these variables `lstyles`
> (LineStyles) and `pstyles` (PointStyles).
>  - Narendra
> On Sat, Mar 21, 2020 at 9:27 PM Eli Zaretskii <eliz@gnu.org> wrote:
>> > From: Narendra Joshi <narendraj9@gmail.com>
>> > Date: Sat, 21 Mar 2020 20:48:52 +0100
>> > Can someone please add this simple `nil' check in the attached patch?
>> Thanks, but could you please provide the rationale?

-- 
Bruno Félix Rezende Ribeiro (oitofelix) [0x28D618AF]
<http://oitofelix.freeshell.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]