[Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window

[Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window

[Eli Zaretskii]

Amin, why was this pushed to the emacs-27 branch?  Is this a bug fix,
and if so, is it safe and/or urgent enough to be put on the release
branch?

Thanks.

Re: [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window

[Amin Bandali]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

Hi Eli,

Eli Zaretskii <eliz@gnu.org> writes:

> Amin, why was this pushed to the emacs-27 branch?  Is this a bug fix,
> and if so, is it safe and/or urgent enough to be put on the release
> branch?
>
> Thanks.
>

Indeed, the two changes address an annoyance/shortcoming myself and some
other ERC users had noticed, but I don't think they were reported on
bugs.gnu.org.  The changes are rather simple and I believe safe enough
for the release branch: they both simply refactor out the implementation
into similarly named internal functions, and provide a new variant that
uses `switch-to-buffer-other-window' rather than `switch-to-buffer'.

I think the changes are simple yet useful enough to be in emacs-27;
though in hindsight, the master branch may have been a better place for
them.  That said, if you or others spot any issues with them, I'd be
more than happy to try and address them, or even revert them if needed.

As a side note, I will be looking into making ERC available on GNU ELPA
so that addition of new features and/or bug fixes wouldn't require
having to run the latest Emacs release or trunk.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

Re: [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window

[Eli Zaretskii]

> From: Amin Bandali <bandali@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Tue, 14 Apr 2020 11:12:34 -0400
> 
> I think the changes are simple yet useful enough to be in emacs-27;
> though in hindsight, the master branch may have been a better place for
> them.  That said, if you or others spot any issues with them, I'd be
> more than happy to try and address them, or even revert them if needed.

The danger is that we release Emacs 27.1 with some problem caused by
these changes undetected.  But if you think this danger is small, I
guess I'm okay with that.

Thanks.

Re: [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window

[Amin Bandali]

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Amin Bandali <bandali@gnu.org>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 14 Apr 2020 11:12:34 -0400
>> 
>> I think the changes are simple yet useful enough to be in emacs-27;
>> though in hindsight, the master branch may have been a better place for
>> them.  That said, if you or others spot any issues with them, I'd be
>> more than happy to try and address them, or even revert them if needed.
>
> The danger is that we release Emacs 27.1 with some problem caused by
> these changes undetected.  But if you think this danger is small, I
> guess I'm okay with that.
>
> Thanks.
>

Makes sense.  In this specific case, I really do think the danger is
small, as I didn't make any changes to the implementation logic for
either of the two original functions, and the two new functions only
differ from the original ones in using `switch-to-buffer-other-window'.
That said if there is anything unclear or suspicious-looking about my
changes, please let me know and I will revert them and apply them to
master instead.

Thanks,
amin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]