From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Multiple definitions of explicit-shell-file-name Date: Thu, 16 Apr 2020 18:54:59 +0100 Message-ID: <87zhbb71u4.fsf@tcd.ie> References: <871rooz4fx.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="45366"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 16 19:56:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jP8ks-000BjH-MI for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Apr 2020 19:56:50 +0200 Original-Received: from localhost ([::1]:37686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP8kr-0004mx-Jr for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Apr 2020 13:56:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40489) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP8jC-000463-JP for emacs-devel@gnu.org; Thu, 16 Apr 2020 13:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jP8jB-0006Nx-FD for emacs-devel@gnu.org; Thu, 16 Apr 2020 13:55:06 -0400 Original-Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:37991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jP8jB-0006Lb-59 for emacs-devel@gnu.org; Thu, 16 Apr 2020 13:55:05 -0400 Original-Received: by mail-ed1-x542.google.com with SMTP id e5so9282218edq.5 for ; Thu, 16 Apr 2020 10:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kEIFcyY5+B39ox8kFHAG3M25xNkqm5Nb2Xv7kQbr7qQ=; b=1xzD9meOK4d1CwQAp6g9ql/1pcFpgzTK4K1puyJmA/HMrb+678sXqIJPx5CWCbMEsh tNKEwpAmz8+1hhZDD72CPyh7yeiU7/uiN2GZUJigo9JOVLY2NXJ+c5C2Ew6KAl3hM9EZ wQXLU0eF6a1nQO2hFkSENB5UEEQhaQzvTobpo4PEpqxjfJGfhGLcos9xWQFgjtMXcaZ+ s7PyMvpZ/n5kq4bneOdReiskNJEPMX+KF1vhXqhwfmwZS0eZA0keVnF3EqBQzpIHBcny 2FncmOtHXbZbG+UbSIiF8Vv/Z1PhwZ8P1h8yva3ET2b13sE60dPFJUNiwE+0BqtsvZX0 Pjjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kEIFcyY5+B39ox8kFHAG3M25xNkqm5Nb2Xv7kQbr7qQ=; b=MZDVxvjB85W+gCED3xIOndVexnkYYAa6QhPzMOVr++AoRZlj8pr93FlxHsQzYuZQXm lJUX7O64MYBuzVca74sh1LH2VieAw0HkktNBgpmcUwbikqE3QLoamBwXHRl3zRmOCIOd KGl304WFA9Nv6g8yMGFt8pcc+LlRBGO1c3N9CRT+ePaT3fhzQE4MI3DZB3ZYZkSE1SSw q1GO8XYaYaMPAr6ZM78qMDbYmBwSCpoa7H2eUpdIlz/C1HQ115ERUaRFRy33np0qjgZw 7G6gfBC0fzcYvO9L6gGPss8GydERX5BN1lsgwP01tOZfXMvV8rex7ghZAIxU1C395oqM j1JA== X-Gm-Message-State: AGi0PuauRicqd0BY9ORSjQp+hpxrJUrRzfg6SU40jSlTpYbxIFtzSgch uAXM5+KDq0lahTLDNPGOnGLwDEbv8wg= X-Google-Smtp-Source: APiQypJEHjpu5awb9jOgX/HSPnQLTQ9fikIXcWe1tdc9o0u1CPVlNmlCQ2URcuKLV1V1lvvqfRSlKw== X-Received: by 2002:a50:cf8e:: with SMTP id h14mr31717318edk.369.1587059701738; Thu, 16 Apr 2020 10:55:01 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id p9sm3054825ejz.71.2020.04.16.10.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2020 10:55:01 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 16 Apr 2020 10:12:04 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::542 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247108 Archived-At: Stefan Monnier writes: >> I noticed that explicit-shell-file-name has been defined as a user >> option in three different places since at least as far back as 1997: >> >> - lisp/shell.el >> - lisp/term.el >> - lisp/obsolete/terminal.el >> >> Each file also assigns it a different custom :group. Can we consolidate >> these duplicates in a single place such as lisp/simple.el, as follows? > > I don't think it belongs in simple.el. It should be in shell.el. I agree, but explicit-shell-file-name is used in contexts unrelated to shell.el, such as ansi-term and dired-insert-directory. Rather than define explicit-shell-file-name in a central place like simple.el, should these external users all check that the variable is bound first? If so, I'll update the patch and send it to the issue tracker for further feedback. Thanks, -- Basil