From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: INSIDE_EMACS and Tramp Date: Sun, 03 May 2020 18:19:17 +0200 Message-ID: <87zhapdm9m.fsf@gmx.de> References: <20200402230535.10490.95720@vcs0.savannah.gnu.org> <20200402230536.E0A3F20CDD@vcs0.savannah.gnu.org> <87lfndarwh.fsf_-_@gmx.de> <87blo78exg.fsf@gmx.de> <871rp357s1.fsf@gmail.com> <87lfmzg3ds.fsf@gmx.de> <87a7397tqz.fsf@gmail.com> <87o8r6wfni.fsf@gmx.de> <87zhapf4v1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="71152"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Federico Tedin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 03 18:22:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVHO4-000IO6-1s for ged-emacs-devel@m.gmane-mx.org; Sun, 03 May 2020 18:22:40 +0200 Original-Received: from localhost ([::1]:47816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVHO2-0007ZV-Tp for ged-emacs-devel@m.gmane-mx.org; Sun, 03 May 2020 12:22:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVHKt-0002sh-1R for emacs-devel@gnu.org; Sun, 03 May 2020 12:19:23 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:55975) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVHKr-0004H4-MZ for emacs-devel@gnu.org; Sun, 03 May 2020 12:19:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588522758; bh=0Wb9dFadgvmVn1nkpX6+Dh91uNXcov4WDRB4HI8THtM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Q4PbqcRuZ3GKsN0YphbAEee3/HtaA+TEtuiKmbTFp2Okur9q0i1rlUYzIyN+knudf AXhFJ/M16oEWIgGSfLTEnpJY4Rh6dnitJ7hg/+CJByqlI2vqK+CKqaBywlzvXT4CN0 CtOnRop0p6yoTN0Npm/zdR4BQcXBxRdoYH3FhEjQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.51.88]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKKUv-1jjDaL0DTL-00LmO9; Sun, 03 May 2020 18:19:18 +0200 In-Reply-To: <87zhapf4v1.fsf@gmail.com> (Federico Tedin's message of "Sun, 03 May 2020 16:52:18 +0200") X-Provags-ID: V03:K1:UY9CIJUIXw9tcqfIFq9EpL7a2yM6p4v7GDy4hAub832hfo7zdfZ EXeF4x/bY85+LuNxbOrSWI//GylAE/3uZ7/Xs6Qaow/Y/8N9T94Pybcu6nHOtqlw726yKfx e0Aybc4ojCtIbbp4H9whVWjq2A8afaiz4cczdQQns+aWSEZc13RmeOTzWLFEoAA7xfoSCNK IbJOY5rxWNUqj81DnoO8w== X-UI-Out-Filterresults: notjunk:1;V03:K0:4aS6qvTNenw=:HHsl2k+J5xN6CUGB5dyk2f 7dvxQkVVnSFkBXphsivBomqpXNC0fFRA9M9C+oxQTpRF3jTWWbgLCk4uFYWCsukyqPA7X5hyQ 4BEDqx1hUb/6jLf5RXTf7yGUR3pIvu5jvew0de1SokEOF83HRZFPaazOjUFfaRUR7SXuSmIB/ RQi9Js4Mqc150h90Gb4BumygNwaVgs3WGTfYuMUZeF6eU0JW6YGfoYqOr+D313hbqaJV5UwP/ 97mb+J8K7KgGPdKLREVmLFSfUER5zFrZijRZtjENez0vPFMYi542++pEOABEYEtxU8HJ1XWto gleyrex4AS8rqxaDKcaxpEzOYCWVRwQrXKw0AaDBE4e0LSTDYfVNUuRl3hL7vOeoyXZCDC/61 4rF2u+NnrHPwwJbI5BW4gAWx4vt4q0rfoCuvzSz5vsDy8OzbXzs61VesOJne207F5N7SW6X1t ZlSDG/gm1AtPofIvZ8PdHcA6KRCP7uA4zbGob8J5Kr5U3XZ8pORW7ArLJQZp0JFZ9J9m8YgIc J5tXO6rIlC/kP1l6CUCvXljrC0mXyIMtt4JfXoZzgSAtQP5W9i8nn1iucoCMA53JIsJDzQ73i sJ24W9mtYURn8CvRqM52TJ46f9pBHv2f4k9JdvS2MdK9zABzpoeTg7vmI5+yW8VMiPP5BGp4W +Uyvt8MKEjl+q+FE079MZY8+nSj8wfDIbKwfCIS55HOy7Njm9XHSmcGjOeOyKJhmM2NjeJ3po tsZLZPhvZ62tJygZbnunilV1selMXqOpk+ylRd/xYN6+OJJa/pwY3SuR7L0oiJbcCS7bH3z5 Received-SPF: pass client-ip=212.227.15.15; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/03 12:19:18 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248711 Archived-At: Federico Tedin writes: > Hey Michael, Hi Federico, > Thanks for creating this patch! I have a couple of > comments/observations. Note that this is my first time reviewing a patch > by mail so formatting may not be very tidy. Your comments look fine. Thanks for them! >> diff --git a/lisp/net/trampver.el b/lisp/net/trampver.el >> index 8d21133b3b..2351867129 100644 >> --- a/lisp/net/trampver.el >> +++ b/lisp/net/trampver.el >> @@ -76,6 +76,13 @@ tramp-repository-version >> (replace-regexp-in-string "\n" "" (emacs-version)))))) >> (unless (string-equal "ok" x) (error "%s" x))) >> >> +;; `inside-emacs-functions' has been introduces with Emacs 28.1. > ^^^^^^^^^^ > typo Fixed. >> +(when (symbolp inside-emacs-functions) >> + (add-hook >> + 'inside-emacs-functions >> + (lambda () >> + (when (file-remote-p default-directory) "tramp:2.5.0-pre")))) > ^^^^^^^^^^^^^^^^^ > > Should this be `tramp-version' instead? All Tramp files in the Emacs git are synchronized from the Tramp git repository, where I develop. In the Tramp git repo, trampver.el is a generated file. The configure script replaces @PACKAGE_VERSION@ by the Tramp version string, so it is dumped directly here. >> --- a/lisp/simple.el >> +++ b/lisp/simple.el >> @@ -4295,6 +4295,29 @@ list-processes >> (tabulated-list-print)) >> (display-buffer buffer) >> nil) >> + >> +(defvar inside-emacs-functions nil >> + "List of functions to compose the environment variable INSIDE_EMACS. >> +Every package which needs to set a string in that envirenmont > ^^^^^^^^^^^ > typo Fixed. > - Fede Best regards, Michael.