Re: INSIDE_EMACS and Tramp

[Michael Albinus <michael.albinus@gmx.de>]

Federico Tedin <federicotedin@gmail.com> writes:

> Hey Michael,

Hi Federico,

> Thanks for creating this patch! I have a couple of
> comments/observations. Note that this is my first time reviewing a patch
> by mail so formatting may not be very tidy.

Your comments look fine. Thanks for them!

>> diff --git a/lisp/net/trampver.el b/lisp/net/trampver.el
>> index 8d21133b3b..2351867129 100644
>> --- a/lisp/net/trampver.el
>> +++ b/lisp/net/trampver.el
>> @@ -76,6 +76,13 @@ tramp-repository-version
>>              (replace-regexp-in-string "\n" "" (emacs-version))))))
>>    (unless (string-equal "ok" x) (error "%s" x)))
>>
>> +;; `inside-emacs-functions' has been introduces with Emacs 28.1.
>                                         ^^^^^^^^^^
>                                            typo

Fixed.

>> +(when (symbolp inside-emacs-functions)
>> +  (add-hook
>> +   'inside-emacs-functions
>> +   (lambda ()
>> +     (when (file-remote-p default-directory) "tramp:2.5.0-pre"))))
>                                                 ^^^^^^^^^^^^^^^^^
>
> Should this be `tramp-version' instead?

All Tramp files in the Emacs git are synchronized from the Tramp git
repository, where I develop. In the Tramp git repo, trampver.el is a
generated file. The configure script replaces @PACKAGE_VERSION@ by the
Tramp version string, so it is dumped directly here.

>> --- a/lisp/simple.el
>> +++ b/lisp/simple.el
>> @@ -4295,6 +4295,29 @@ list-processes
>>      (tabulated-list-print))
>>    (display-buffer buffer)
>>    nil)
>> +
>> +(defvar inside-emacs-functions nil
>> +  "List of functions to compose the environment variable INSIDE_EMACS.
>> +Every package which needs to set a string in that envirenmont
>                                                      ^^^^^^^^^^^
>                                                         typo

Fixed.

> - Fede

Best regards, Michael.