From: Kevin Brubeck Unhammer <unhammer@fsfe.org>
Cc: 32723@debbugs.gnu.org
Subject: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers
Date: Sun, 10 May 2020 21:45:54 +0200 [thread overview]
Message-ID: <87zhaffua5.fsf@fsfe.org> (raw)
In-Reply-To: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> (Martin Kletzander's message of "Wed, 12 Sep 2018 17:44:29 +0200")
[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]
Martin Kletzander <nert.pinx@gmail.com> čálii:
> When auto-joining channel with the same name on
> multiple channels the auto-join will go over the
> list of channels and for each one it checks if
> there is a buffer and alive server process.
> However it does not check if the server process
> matches the server being currently processed for
> auto-joining.
>
> This happens since commit "Don't join erc channels
> doubly"
>
> Fix it by checking if the currently processed
> server matches the erc process name of the already
> joined channel.
That's not always going to match though. The car's of
erc-autojoin-channels contain the values of erc-server-announced-name or
erc-session-server, not the process-name of
erc-server-process. E.g. when I join my weechat relay,
erc-session-server is "example.com" and erc-server-announced-name is
"weechat.relay.irc" while (process-name erc-server-process) is
"erc-example.com-9001<1>".
Also, the check is against the current erc-server-process (for the
server being joined). Isn't the intention of the patch to check against
the candidate buffer's server-process?
I would expect something like
(when (or (not buffer)
;; If the same channel is joined on another
;; server the best-effort is to just join
(not (with-current-buffer buffer
(or (string-match-p (car l) erc-session-server)
(string-match-p (car l) erc-session-announced-name))))
(not (with-current-buffer buffer
(erc-server-process-alive))))
(erc-server-join-channel server chan))
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-05-10 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 15:44 bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers Martin Kletzander
2019-06-23 21:53 ` Lars Ingebrigtsen
2020-05-10 19:45 ` Kevin Brubeck Unhammer [this message]
[not found] ` <87ftc7h9gp.fsf@fsfe.org>
2020-05-11 15:06 ` Martin Kletzander
2020-05-19 18:25 ` Martin Kletzander
2020-05-19 18:40 ` Kevin Brubeck Unhammer
2020-05-19 20:32 ` Corwin Brust
2020-06-09 14:52 ` Martin Kletzander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhaffua5.fsf@fsfe.org \
--to=unhammer@fsfe.org \
--cc=32723@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.