From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#42383: 28.0.50; Two bugs with M-x compile Date: Thu, 16 Jul 2020 17:39:57 -0400 Message-ID: <87zh7zrvf6.fsf@gmail.com> References: <83h7u7lcaf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10769"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings , 42383@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 16 23:41:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwBcs-0002ge-Tv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 23:41:10 +0200 Original-Received: from localhost ([::1]:59318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwBcr-0004k9-Jv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 17:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwBck-0004k1-3V for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 17:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jwBcj-0008NC-QT for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 17:41:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jwBcj-0000Vn-Nz for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 17:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jul 2020 21:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42383 X-GNU-PR-Package: emacs Original-Received: via spool by 42383-submit@debbugs.gnu.org id=B42383.15949356111900 (code B ref 42383); Thu, 16 Jul 2020 21:41:01 +0000 Original-Received: (at 42383) by debbugs.gnu.org; 16 Jul 2020 21:40:11 +0000 Original-Received: from localhost ([127.0.0.1]:56101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwBbv-0000Ua-EU for submit@debbugs.gnu.org; Thu, 16 Jul 2020 17:40:11 -0400 Original-Received: from mail-qt1-f176.google.com ([209.85.160.176]:42410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwBbq-0000Ts-G9 for 42383@debbugs.gnu.org; Thu, 16 Jul 2020 17:40:10 -0400 Original-Received: by mail-qt1-f176.google.com with SMTP id e12so6138283qtr.9 for <42383@debbugs.gnu.org>; Thu, 16 Jul 2020 14:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=E5nYyUkOasmh0lrQwNuERCxDziQGZoNZmWwv5xrNl60=; b=lgjPMBlaPZqR+h8t3MR1yKJZrPCyzsfjXCRcgyJXvERytg697jOTRYHK8aBj0lrPxr 6iin6NlCzan+aFcGdk7fJgR30rBIMc8HWGXDVN1qsAXjQJ1OHOrVCIXX6DzcJSmnkY6M iFzukGhYcFL2loVdA7lopZJoPjBwi7FEmTLmspCrJzr+SENBlHZxL7Naathlr3l8XT9E PT++LfuYG+7wY9A7mjN0psgBgxEucbNtYo8Y8+CUIuGLfNc04VLKvQIp7vY4P1Urvfb5 RaDSyx2KaKNH4wlb5EMuvdPsc2YGJMKxt6O+A0jeZNBpK94hP1VSmp78npHhghU3A1tH rIwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=E5nYyUkOasmh0lrQwNuERCxDziQGZoNZmWwv5xrNl60=; b=RzOV3s6qbtoONccwTeVIH4X0Uc+dJ8qAeD1wBI9yX8RyOUzmWyMhEWFqDIX5C2VU1E BcsXem0DjSvR7K9jjWvpYtYesnr6e+tTovRt+rkQB12dwrIaHbLgST0I0ZhPYzboXgxE bbN8cOyPt1wWl02rDLvORJ4zs2ZsryHz3KXxMsmGPs/Y35RW7ef2AgV44KZEd90PzKHF 35tkoOmDzC1Aq/SOL+6CcVp8DvG2O01crsFuZfsigAQjoVjk3pNkupUhcjKzqcARQr5H ZuaxDPPG0ni2pkqBJjv5w/hwqggU+gZXo03NeeCC+WTTjHoAlEVdesafZ6WeElL0d4XG VHWg== X-Gm-Message-State: AOAM533zy0/HNGM44fbNNUWszDRUlpYZpMTMBB88sastsvrRYUp6Aa8i P+DoBk39GxFoE5yrFhNAVHvmZ3Nc X-Google-Smtp-Source: ABdhPJzN7MpNQDyZWy1TzPUCdvkg4rYtwzrC7q484YXA1sWyBnywPCbtVPoE7+aEndJZu9vhkIQv0g== X-Received: by 2002:ac8:6c29:: with SMTP id k9mr7375338qtu.290.1594935599640; Thu, 16 Jul 2020 14:39:59 -0700 (PDT) Original-Received: from mars (c-73-163-194-78.hsd1.dc.comcast.net. [73.163.194.78]) by smtp.gmail.com with ESMTPSA id i26sm8807369qkh.14.2020.07.16.14.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 14:39:58 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 16 Jul 2020 14:55:05 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183116 Archived-At: On Thu 16 Jul 2020 at 14:55, Stefan Monnier wrote: > * lisp/shell.el (shell-dynamic-complete-functions): Move > pcomplete-completions-at-point down the list so that filename > completion has a chance to complete before pcompletion. > > Fixes bug#34330 > > yet, `pcomplete-completions-at-point` is supposed to perform filename > completion also (via `pcomplete-default-completion-function`), so > I think `pcomplete-completions-at-point` should come first and I suspect > that the problem in bug#34330 is internal to pcomplete and the above > commit just worked around it. I find pcomplete really confusing (why is it that there's a whole second kind of completion framework outside completion-at-point?). But yes, sounds like this should be reverted. I didn't notice this regression since I use ivy which obviates the need to re-complete after typing a letter. Someone will need to reopen bugs #10417 and #34330. Alex