From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42536: 28.0.50; Test vc-test-svn00-create-repo failing if snvadmin program not installed Date: Tue, 04 Aug 2020 14:49:03 +0200 Message-ID: <87zh7ao9ts.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9101"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42536@debbugs.gnu.org To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 04 14:50:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2wOQ-0002FN-1b for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Aug 2020 14:50:10 +0200 Original-Received: from localhost ([::1]:34736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2wOP-0002M6-33 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Aug 2020 08:50:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2wOI-0002Ls-KU for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2020 08:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2wOI-0000bS-B1 for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2020 08:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k2wOI-0005Qj-6Y for bug-gnu-emacs@gnu.org; Tue, 04 Aug 2020 08:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Aug 2020 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42536 X-GNU-PR-Package: emacs Original-Received: via spool by 42536-submit@debbugs.gnu.org id=B42536.159654535720804 (code B ref 42536); Tue, 04 Aug 2020 12:50:02 +0000 Original-Received: (at 42536) by debbugs.gnu.org; 4 Aug 2020 12:49:17 +0000 Original-Received: from localhost ([127.0.0.1]:47095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2wNZ-0005PU-0t for submit@debbugs.gnu.org; Tue, 04 Aug 2020 08:49:17 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:56014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2wNW-0005PE-GT for 42536@debbugs.gnu.org; Tue, 04 Aug 2020 08:49:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rxFkiG1j4Un1dD5e28sChQjKzaey1I/+MWhu4QqdjCk=; b=C8MbNBexS7S0C8/cbEZ868xDVO Vfy0gmVZTPKGnH5T3oBi3m12fgqYZzKUrixZVfqx7dqQ+0zLlYuP9HwQVNl1W4BZ/yhLuLlh4zSYU 02RuIQvrKzOZ04bBFX/UUO3jDUb6/pWqgYfuT+7JO2dD/okBTeUc7A6bi3e35RkvcmRQ=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2wNN-0007jL-Hj; Tue, 04 Aug 2020 14:49:08 +0200 In-Reply-To: (Philipp's message of "Sat, 25 Jul 2020 20:43:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183994 Archived-At: Philipp writes: > This is another follow-up to Bug#30700. In this case, it's probably > unrelated to macOS, and the SVN tests should simply check whether SVN is > actually installed. However, since the tests are autogenerated by a > macro, this isn't entirely trivial: > > Test vc-test-svn00-create-repo backtrace: > call-process("svnadmin" nil t nil "create" "SVN") Hm... I don't have svn on my Linux laptop either, and the svn tests are just not done there. So why are they performed on an svn-less Macos laptop? Aaah! larsi@space test % svn svn: error: The subversion command line tools are no longer provided by Xcode. So (defun vc-test--svn-enabled () (executable-find vc-svn-program)) evaluates to true, even if there's no useable svn on the system. Thank you, Apple! I've now amended the test to check for svnadmin, too. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no