all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philipp <p.stephani2@gmail.com>
Cc: 42536@debbugs.gnu.org
Subject: bug#42536: 28.0.50; Test vc-test-svn00-create-repo failing if snvadmin program not installed
Date: Tue, 04 Aug 2020 14:49:03 +0200	[thread overview]
Message-ID: <87zh7ao9ts.fsf@gnus.org> (raw)
In-Reply-To: <m2h7tv1llq.fsf@gmail.com> (Philipp's message of "Sat, 25 Jul 2020 20:43:45 +0200")

Philipp <p.stephani2@gmail.com> writes:

> This is another follow-up to Bug#30700.  In this case, it's probably
> unrelated to macOS, and the SVN tests should simply check whether SVN is
> actually installed.  However, since the tests are autogenerated by a
> macro, this isn't entirely trivial:
>
> Test vc-test-svn00-create-repo backtrace:
>   call-process("svnadmin" nil t nil "create" "SVN")

Hm...  I don't have svn on my Linux laptop either, and the svn tests are
just not done there.  So why are they performed on an svn-less Macos
laptop?

Aaah!

larsi@space test % svn
svn: error: The subversion command line tools are no longer provided by Xcode.

So

(defun vc-test--svn-enabled ()
  (executable-find vc-svn-program))

evaluates to true, even if there's no useable svn on the system.  Thank
you, Apple!

I've now amended the test to check for svnadmin, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-08-04 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25 18:43 bug#42536: 28.0.50; Test vc-test-svn00-create-repo failing if snvadmin program not installed Philipp
2020-08-04 12:49 ` Lars Ingebrigtsen [this message]
2020-08-04 16:29   ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh7ao9ts.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=42536@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.