From: Lars Ingebrigtsen <larsi@gnus.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 39546@debbugs.gnu.org, michael.albinus@gmx.de,
Tassilo Horn <tsdh@gnu.org>
Subject: bug#39546: 28.0.50; Do not require subr-x at run time
Date: Sat, 08 Aug 2020 16:06:12 +0200 [thread overview]
Message-ID: <87zh75xmej.fsf@gnus.org> (raw)
In-Reply-To: <87pnea8zjo.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 19 Feb 2020 14:41:31 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> -;;;###autoload
>> (defmacro when-let (spec &rest body)
>> "Bind variables according to SPEC and conditionally evaluate BODY.
>
> Sorry; I haven't been following this thread closely, but I don't think
> this is a good idea. It means putting
>
> +(eval-when-compile (require 'subr-x))
>
> in more and more files, for no particularly good reason that I can see?
>
> What's the reason for removing this autoload?
I think the conclusion was (in a discussion in a different bug report,
if I remember correctly) that it's fine to ;;;###autoload when-let, and
it's also fine to require subr-x at run time (i.e., it's not just macros
and defsubsts).
So I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-08-08 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 13:59 bug#39546: 28.0.50; Do not require subr-x at run time Tino Calancha
2020-02-10 14:54 ` Michael Albinus
2020-02-10 17:35 ` Tino Calancha
2020-02-10 15:31 ` Eli Zaretskii
2020-02-10 17:26 ` Tino Calancha
2020-02-10 17:39 ` Eli Zaretskii
2020-02-10 19:19 ` Tassilo Horn
2020-02-10 19:59 ` Eli Zaretskii
2020-02-10 20:17 ` Tassilo Horn
2020-02-10 19:30 ` Tino Calancha
2020-02-10 19:54 ` Tassilo Horn
2020-02-10 20:34 ` Tino Calancha
2020-02-10 20:49 ` Tino Calancha
2020-02-10 21:00 ` Tino Calancha
2020-02-14 10:16 ` Eli Zaretskii
2020-02-19 13:41 ` Lars Ingebrigtsen
2020-08-08 14:06 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh75xmej.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=39546@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=tino.calancha@gmail.com \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.