bug#21857: package install should give better feedback

bug#21857: package install should give better feedback

[David Reitter]

When installing a package, give an acceptable “XXX successfully installed” message in the echo area as the last message.
As it is, it seems to just show a “done” for the last dependency, which is confusing or uninformative.

Also, if the *Packages* buffer is present--which it will be because the user may have picked the package to install after doing M-x list-packages—this buffer should be updated to show that the package was installed.

(Observed in master branch, installing JDEE from MELPA.)

bug#21857: package install should give better feedback

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

On 7 Nov 2015 11:41 pm, "David Reitter" <david.reitter@gmail.com> wrote:
>
> When installing a package, give an acceptable “XXX successfully
installed” message in the echo area as the last message.
>
> Also, if the *Packages* buffer is present this buffer should be updated
to show that the package was installed.

Agree with all of it.
And if anyone would like to try their hand at it, both issues should be
very easy to fix.

[-- Attachment #2: Type: text/html, Size: 566 bytes --]

bug#21857: PATCH to show message after `package-install` installs successfully

[Ryan Olson]

When `package-install` function finishes successfully, this patch
(below) shows the message "Package `package-name` installed."  This
matches the message that is shown with the function `package-delete`.
I feel like this solves the primary issue: messaging.  After this
patch, the user should know that everything was a success.

*** package.el.orig 2020-01-17 10:11:48.000000000 -0700
--- package.el 2020-01-17 10:12:36.000000000 -0700
*************** to install it but still mark it as selec
*** 2076,2082 ****
                   (package-compute-transaction () (list (list pkg))))))
          (progn
            (package-download-transaction transaction)
!           (package--quickstart-maybe-refresh))
        (message "`%s' is already installed" name))))

  (defun package-strip-rcs-id (str)
--- 2076,2083 ----
                   (package-compute-transaction () (list (list pkg))))))
          (progn
            (package-download-transaction transaction)
!           (package--quickstart-maybe-refresh)
!           (message "Package `%s' installed." name))
        (message "`%s' is already installed" name))))

  (defun package-strip-rcs-id (str)

bug#21857: PATCH to show message after `package-install` installs successfully

[Ryan Olson]

Switched patch to `diff -u` variant.

--- package.el.orig 2020-01-17 10:11:48.000000000 -0700
+++ package.el 2020-01-17 10:12:36.000000000 -0700
@@ -2076,7 +2076,8 @@
                  (package-compute-transaction () (list (list pkg))))))
         (progn
           (package-download-transaction transaction)
-          (package--quickstart-maybe-refresh))
+          (package--quickstart-maybe-refresh)
+          (message "Package `%s' installed." name))
       (message "`%s' is already installed" name))))

 (defun package-strip-rcs-id (str)

On Fri, Jan 17, 2020 at 10:53 AM Ryan Olson <ryan.olson.x@gmail.com> wrote:
>
> When `package-install` function finishes successfully, this patch
> (below) shows the message "Package `package-name` installed."  This
> matches the message that is shown with the function `package-delete`.
> I feel like this solves the primary issue: messaging.  After this
> patch, the user should know that everything was a success.
>
> *** package.el.orig 2020-01-17 10:11:48.000000000 -0700
> --- package.el 2020-01-17 10:12:36.000000000 -0700
> *************** to install it but still mark it as selec
> *** 2076,2082 ****
>                    (package-compute-transaction () (list (list pkg))))))
>           (progn
>             (package-download-transaction transaction)
> !           (package--quickstart-maybe-refresh))
>         (message "`%s' is already installed" name))))
>
>   (defun package-strip-rcs-id (str)
> --- 2076,2083 ----
>                    (package-compute-transaction () (list (list pkg))))))
>           (progn
>             (package-download-transaction transaction)
> !           (package--quickstart-maybe-refresh)
> !           (message "Package `%s' installed." name))
>         (message "`%s' is already installed" name))))
>
>   (defun package-strip-rcs-id (str)

bug#21857: Feedback / Merge on patch

[Ryan Olson]

What can I do to get this merged into emacs master?  Any feedback on my patch?

bug#21857: PATCH to show message after `package-install` installs successfully

[Noam Postavsky]

Ryan Olson <ryan.olson.x@gmail.com> writes:

> What can I do to get this merged into emacs master?  Any feedback on my patch?

The patch looks fine.  It would help if it included a commit log message
(as described in CONTRIBUTE).  That way it's a bit less work to merge
it, and is therefore more likely to happen.

bug#21857: PATCH to show message after `package-install` installs successfully

[Ryan Olson]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

Noam Postavsky <npostavs@gmail.com> wrote:
> The patch looks fine.  It would help if it included a commit log message
> (as described in CONTRIBUTE).  That way it's a bit less work to merge
> it, and is therefore more likely to happen.

Thanks! Attached is a new patch created using instructions found in CONTRIBUTE.

[-- Attachment #2: 0001-Show-friendly-message-after-package-install.patch --]
[-- Type: application/octet-stream, Size: 1130 bytes --]

From e8c08bc17c5a453ea0ba52f9afe2dcb36ecc98a7 Mon Sep 17 00:00:00 2001
From: Ryan Olson <ryanolsonx@gmail.com>
Date: Sun, 23 Feb 2020 08:15:10 -0700
Subject: [PATCH] Show friendly message after package install

Once we know the package has successfully been installed using the
`package-install` command, instead of relying on the compile "Done"
message, give a message that tells the user that the package has been
installed. (Bug#21857)
---
 lisp/emacs-lisp/package.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index c91ee445e1..43eb038a86 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2081,7 +2081,8 @@ package-install
                  (package-compute-transaction () (list (list pkg))))))
         (progn
           (package-download-transaction transaction)
-          (package--quickstart-maybe-refresh))
+          (package--quickstart-maybe-refresh)
+          (message  "Package `%s' installed." name))
       (message "`%s' is already installed" name))))
 
 (defun package-strip-rcs-id (str)
-- 
2.23.0

bug#21857: PATCH to show message after `package-install` installs successfully

[Noam Postavsky]

Ryan Olson <ryan.olson.x@gmail.com> writes:

> Noam Postavsky <npostavs@gmail.com> wrote:
>> The patch looks fine.  It would help if it included a commit log message
>> (as described in CONTRIBUTE).  That way it's a bit less work to merge
>> it, and is therefore more likely to happen.
>
> Thanks! Attached is a new patch created using instructions found in CONTRIBUTE.

Thanks, I've pushed it to master after adding ChangeLog formatting.  I'm
leaving this bug open, since there's also a mention of updating the
*Packages* buffer.

[1: 4a94881345]: 2020-02-25 19:42:08 -0500
  Show friendly message after package install
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4a94881345819dd68062bc729b5b7ddeab00041b

bug#21857: package install should give better feedback

[Lars Ingebrigtsen]

David Reitter <david.reitter@gmail.com> writes:

> When installing a package, give an acceptable “XXX successfully
> installed” message in the echo area as the last message.
> As it is, it seems to just show a “done” for the last dependency,
> which is confusing or uninformative.

This was fixed, apparently.

> Also, if the *Packages* buffer is present--which it will be because
> the user may have picked the package to install after doing M-x
> list-packages—this buffer should be updated to show that the package
> was installed.

If I `I' and then `x', the package buffer is updated.  Do you have a
recipe to reproduce this bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#21857: package install should give better feedback

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

No recipe, too old - I no longer maintain Aquamacs. If the first bug was
fixed and there is a way to update it, so be it. Automatic update is
suggested.

On Sun, Aug 9, 2020 at 14:09 Lars Ingebrigtsen <larsi@gnus.org> wrote:

> David Reitter <david.reitter@gmail.com> writes:
>
> > When installing a package, give an acceptable “XXX successfully
> > installed” message in the echo area as the last message.
> > As it is, it seems to just show a “done” for the last dependency,
> > which is confusing or uninformative.
>
> This was fixed, apparently.
>
> > Also, if the *Packages* buffer is present--which it will be because
> > the user may have picked the package to install after doing M-x
> > list-packages—this buffer should be updated to show that the package
> > was installed.
>
> If I `I' and then `x', the package buffer is updated.  Do you have a
> recipe to reproduce this bug?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[-- Attachment #2: Type: text/html, Size: 1532 bytes --]

bug#21857: package install should give better feedback

[Lars Ingebrigtsen]

David Reitter <david.reitter@gmail.com> writes:

> No recipe, too old - I no longer maintain Aquamacs. If the first bug
> was fixed and there is a way to update it, so be it. Automatic update
> is suggested.

OK; then I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no