From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#26911: 25.2; eshell "cd .." doesn't work correctly with TRAMP Date: Sat, 05 Sep 2020 17:57:56 +0200 Message-ID: <87zh64tdvf.fsf@gmx.de> References: <83sgc7z220.fsf@gnu.org> <83r1rryrk0.fsf@gnu.org> <47047d69-91aa-fd0d-1510-64ba7c246970@cs.ucla.edu> <83a6yeynd1.fsf@gnu.org> <03a31052-795a-c169-c199-2b0f3ba88ec2@cs.ucla.edu> <83sgc5xq8k.fsf@gnu.org> <164450fe-7f86-e336-87d4-13c52e52c61c@cs.ucla.edu> <83eenoxm18.fsf@gnu.org> <6acf8cfa-6071-e7b1-3055-04292634bb39@cs.ucla.edu> <83sgc2x3p2.fsf@gnu.org> <83imcuvkhd.fsf@gnu.org> <871rjhsqmr.fsf@gmx.de> <83lfhpu3st.fsf@gnu.org> <87wo19r6m2.fsf@gmx.de> <83eenhtxjv.fsf@gnu.org> <87r1rhr0rw.fsf@gmx.de> <838sdpqw07.fsf@gnu.org> <87363wr59c.fsf@gmx.de> <83lfhopj3t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10142"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 26911@debbugs.gnu.org, mattiase@acm.org, eggert@cs.ucla.edu, yegortimoshenko@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 17:59:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEabD-0002X3-Jj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 17:59:31 +0200 Original-Received: from localhost ([::1]:49520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEabC-00017m-Cq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 11:59:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEaak-00017a-Es for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEaak-0007kP-5s for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEaak-0005Hq-2w for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26911 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 26911-submit@debbugs.gnu.org id=B26911.159932149920274 (code B ref 26911); Sat, 05 Sep 2020 15:59:02 +0000 Original-Received: (at 26911) by debbugs.gnu.org; 5 Sep 2020 15:58:19 +0000 Original-Received: from localhost ([127.0.0.1]:43934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaa3-0005Gw-2X for submit@debbugs.gnu.org; Sat, 05 Sep 2020 11:58:19 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:47035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaa1-0005Gi-G4 for 26911@debbugs.gnu.org; Sat, 05 Sep 2020 11:58:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599321478; bh=3KfN1ADiDOSVudBuN0Pz6arpykF7PVlgse2hqtcNzpk=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=iC78aq/bOo8Dw9JrKbl6HmIqZwFQSdV7G2DAyrE3pqFvcDC/38y1ehn5ruu+yUU5i 3S4ZxIYBsFNLqTS3kKZSKNTNS0rVfw2sfIi30KLtqKedy0ygXEx6wIRZ15tNfy3teS ea78biYcuxAA2q46pKpGBZZWpW4RXEoPvhh/ZtrI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.243.3]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MowGa-1kuklU2ffy-00qOde; Sat, 05 Sep 2020 17:57:58 +0200 In-Reply-To: <83lfhopj3t.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Sep 2020 14:18:30 +0300") X-Provags-ID: V03:K1:bqP4ku+gpYvQnz1Aarxdu3tFb6xryEOlbd7AA5bM3qpaN1OmizD 2+TqXtor2YtMgUV41gEnmn5o1HBsnC8i/Mmp6tbJ7X/6DThoq6+nxEHZTF+Dvmy7u8mqWch vYrNR+I7i8+lFs2GmJjfhWi7L15f6U0Of+svPOe4z+Spm8dXgzJIpKv7+UISzbyWSBiLVTI wR+aMYzsn8kajGYlCisyQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:qw7CK48Y2o0=:AaaeCt8nlPCojFSwFg7JoY T7cwrpcdM4JEHWSF/HRLsKc9q0m9xna0Yuf6ibTQU1ofv25zM1FPCDvYTwQACTZzOl9WUcu5K i7P5Yy6IZkxpAsAHyQTEdJy6P2tozZzTCqA50JCJ+neU97Vmw+LFMqOviZfKHFQ7aMawZ5fXG t4ttRDNKrHLe1s1PtYY/FImtuIZE0yR/G9BxWmPQtgp7Jr29lDXyHQYO0FWapjK5nTdjfIuuR XG1eSrlm41zFmF+jBEMSUhTygIt5t5IBbRiDuhqtJxmcmxdAUaAh6bhIa1mCU+7xXWhmYLfR2 y/xgSGQMK0N8SNebZHxJlATW+moLvkQODvKhFTpc/67Y2XPUprWUUFqije4OBYefIP1SFrFX5 LGjcVtzMksC0vmXVoHU1rIRivmqc22Sxv2gs4Abv6jmtRGYeATassMzMzHcrEE0Lhd9uaB16f ZQm0HCCIsyGYaO54Th7GmpDaQ8D53RKHxs/CscU6qzNp1YVFjEDs2GgQJuSUonb6JuFlIjsQQ wQvlsmiJMeHwFfFC+RCzbizoyz62zArgZBT8/u15SpDNE/NqKmAjNV6nSxuySqXFsykWW+Svw VQLz6rk4RSxj2hyrSkiNHQ3fkuFk/b4IYJ5aIJdjwrtKliyt7FU/QhxBFI6+HOBPZ6ja31EjX WNYwpb0V3aq2Doxl5ZGc3TdAQwGI5qVh1DgP3tOky02QzK/4LihnZe0IhLd3pCGgNfPzr7c4z kA+QT0Sv+mR/0qZgqdWg/TguAwAI/OHV5FBlhn9TBx1LNqlYmjo+cS5jwfoHMh3NtPtNECMT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187273 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: Hi Eli, > First, I think I know the reason for the problem I had yesterday to > run all the tests. There's some problem in the Tramp tests that > causes almost each test that was run to leave 3 processes on the > remote system: 2 sshd's and 1 /bin/sh. AFAICT, these are created by > the first connection made by each test. Most tests create additional > connections, but their processes are all killed or exit when the test > completes, whereas this one connection is left behind. And some test > leave behind more than one such triplet. So after running enough > tests, the system is full of these triplets of zombie processes, and > on a resource-challenged system that could cause additional > connections to fail due to lack of resources to start another process. > > Is it possible to make sure these processes are killed as part of each > test's cleanup? For now, I ran the tests one by one, each time > killing the zombie processes manually on the remote system. It took > some time... Most of the tests start with (skip-unless (tramp--test-enabled)). This defun calls tramp-cleanup-connection, which shall also kill all related Tramp processes. Doesn't seem to work on MS Windows. Hard to debug for me w/o such a machine. Could you write a bug report as a reminder for me, that I investigate when I have such a machine? > Anyway, doing this cleanup manually allowed me to run all the tests > (skipping those which I knew to be "unstable"), and all but one of > them succeeded. The one which failed is shown below together with the > failure description: > > Test tramp-test30-make-process condition: > (ert-test-failed > ((should > (string-match > (if ... "unknown signal > \\'" "killed.* > \\'") > (buffer-string))) > :form > (string-match "unknown signal > \\'" "killed > ") > :value nil)) > FAILED 1/1 tramp-test30-make-process (39.250000 sec) > > Just to be sure, I've ran this test twice, and each time it failed > with the same error. Hahh! There is a special case in that test for MS-Windows: --8<---------------cut here---------------start------------->8--- (should (string-match (if (eq system-type 'windows-nt) "unknown signal\n\\'" "killed.*\n\\'") (buffer-string)))) --8<---------------cut here---------------end--------------->8--- IIRC, somebody has reported this different return message. Or maybe I have seen this on the MS Windows machine I've used for testing. Maybe we shall simply allow both messages, because the exact wording doesn't matter. What about the appended patch? > Thanks. Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable *** /tmp/ediff7ZRJwF 2020-09-05 17:54:46.315839349 +0200 =2D-- /home/albinus/src/tramp/test/tramp-tests.el 2020-09-05 17:53:23.6875= 80606 +0200 *************** *** 4498,4508 **** ;; Read output. (with-timeout (10 (tramp--test-timeout-handler)) (while (accept-process-output proc 0 nil t))) ! (should ! (string-match ! (if (eq system-type 'windows-nt) ! "unknown signal\n\\'" "killed.*\n\\'") ! (buffer-string)))) ;; Cleanup. (ignore-errors (delete-process proc))) =2D-- 4498,4504 ---- ;; Read output. (with-timeout (10 (tramp--test-timeout-handler)) (while (accept-process-output proc 0 nil t))) ! (should (string-match "unknown signal\\|killed" (buffer-string)))) ;; Cleanup. (ignore-errors (delete-process proc))) --=-=-=--