From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#43308: 28.0.50; Improvements to Edit->Search menu Date: Thu, 10 Sep 2020 22:18:51 +0800 Message-ID: <87zh5xiuk4.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32698"; mail-complaints-to="usenet@ciao.gmane.io" To: 43308@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 10 16:20:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGNQo-0008OA-P1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 16:20:10 +0200 Original-Received: from localhost ([::1]:51262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGNQn-0004mL-Qg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 10:20:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGNQg-0004lX-TL for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 10:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGNQg-0006bI-Js for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 10:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGNQg-0004s5-F7 for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 10:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43308 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.159974760018711 (code B ref -1); Thu, 10 Sep 2020 14:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Sep 2020 14:20:00 +0000 Original-Received: from localhost ([127.0.0.1]:40846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGNQd-0004rj-OS for submit@debbugs.gnu.org; Thu, 10 Sep 2020 10:20:00 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:45864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGNQb-0004rb-TY for submit@debbugs.gnu.org; Thu, 10 Sep 2020 10:19:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGNQb-0004k8-MI for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 10:19:57 -0400 Original-Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:34680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGNQZ-0006ak-MF for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 10:19:57 -0400 Original-Received: by mail-pf1-x42e.google.com with SMTP id v196so4849242pfc.1 for ; Thu, 10 Sep 2020 07:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=w+lNdTjAyaY404CkepRTyN1nLSKzQrzmhZRe2wGhUas=; b=tIBnhE2NnNnLI9DSVErwaAbGFC04woIRO38Kwf2CYfMGy75yTSKcHSd52XMp1deBxK Qfb54J+2LmM0HBMCzn4mUTBBL4EMbuHu6Ola0ZuGdldTsWE3Wo+KDJIxxrzr7ikt3x6X XmuPMU4HxQVM+pCZrDzkMxNkrTXHU80baVsv9p9mxJMEnCIrASNCKqqfIBQ86H7dEknG thE5CHw3ys4Wk+VKzOp6gR9W42/xlNARo6L7oh15Ep/UvXLV5V82nFjlwzhaSqIbnbIw 5chnn+oe51n70ARjh4HFe9IhaeR1XIY+cVsE1FSMJPrmuldt39kexkG+0Z8dU/+xy+6/ GDIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=w+lNdTjAyaY404CkepRTyN1nLSKzQrzmhZRe2wGhUas=; b=n2oULx4zDeN/6e+0G6H2LUlsLD55EPAJ+GwN1TUeJ+KoUuORUtM21cWCXL5zikD72+ qFrQJLKZZRPSdXSrZHrtR7Dr6ANQJtffGXsJ4yG9ugNEFqMK8PUjCA0qsszye6f2sVIS rLxCysA7WEKvGFL3/yD4+Yn3W6r2Lty7Qv38JLqrRE6da0k5ewSdDVbX87Znjv/HoiqS CM4N6e3IdDwHS4pHfO5FH3PgLuZKUCw4HfkQOrjfKQPRZNINvCUru7e2xx9G3Lu+OHNR ub3CuLnsuPRrcXXUPlNaqtMgXFGjyixIb22e1d7V/xVBl8bFdzrfeAT1xBT2jII8Qz5Q 154Q== X-Gm-Message-State: AOAM531403uqO5uYUKXKsH7fdneTSMsvghT60hgxMdovMDiG+6ZhEt2H nlVoDM9HRS0zKgzBLRYXnqNWb3e9RMJ7x8jv X-Google-Smtp-Source: ABdhPJzPLTmFqpAu36gk4Mb8JrHfPLFSPMPVbU0jVu4GF71eNMAkBtE7/71CXk1Pe2aOO9JYmBioZw== X-Received: by 2002:a63:242:: with SMTP id 63mr4513251pgc.375.1599747593578; Thu, 10 Sep 2020 07:19:53 -0700 (PDT) Original-Received: from localhost ([104.250.131.79]) by smtp.gmail.com with ESMTPSA id b144sm5990644pfb.48.2020.09.10.07.19.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 07:19:52 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=yantar92@gmail.com; helo=mail-pf1-x42e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187735 Archived-At: Following up with "Changes for emacs 28" discussion about improving menu [1] Source: http://ergoemacs.org/emacs/modernization_menu.html The following menus seems to be more confusing than helpful: - Edit->Search menu->String Forward - Edit->Search menu->String Backwards - Edit->Search menu->Regexp Forward - Edit->Search menu->Regexp Backwards - Edit->Search menu->Repeat Forward - Edit->Search menu->Repeat Backwards In most of other applications, the search functionality is squeezed into single search dialogue, providing searching forward, backwards, and repeating search together (via next/prev buttons). Current Emacs menu forces the user to click Edit->Search menu->... multiple times to repeat the search. That is not a pleasant experience. Also, the functionality of the above menu items seems to be strictly inferior in comparison with isearch items from Edit->Search->Incremental search sub-menu. The only apparent advantage is that user would not need to know that moving to next/prev match is C-s/C-r. The article suggests to remove the above Search menu items completely and replace them by incremental search versions. I would also add that we can show transient next match/previous match toolbar icons to assist users, unfamiliar with key bindings. Though need to make sure that these new toolbar icons can be easily associated with the search process. For example, we may show additional toolbar at the bottom (above the mini-buffer isearch prompt) with only these two new toolbar icons (maybe also "exit search" icon). Also, the article suggests to rename "Forward/Backward String..." into "Search Forward/Backwards...", which sounds reasonable since non-programmer users may be confused by the meaning of word "String". Finally, find "Search tagged files..." and the following "Repeat" menu confusing. What does "tagged files" mean? I tried to click it, got a prompt about regex, then prompt about tag table (what is it?). Finally, I got error "File ~/TAGS does not exist". This made me recall vague memory about Emacs manual talking about some kind of completion feature for large code projects - something I never used. The above is my actual first impression. The menu seems useless for me, though may have a value for programmers. However, I have two suggestions: 1. Menu items do not show the key binding (is in Incremental search menu). I think that showing bindings is generally a great idea for discoverability 2. There is currently no way to understand what some unfamiliar menus do except blindly trying. As I explained about, it does not always help. Probably, Emacs could show some kind of tooltip on top of menu items, explaining what it does in more details. Also, it would be cool to be able to move to Manual page talking about topic relevant to the menu item (on right click?). Best, Ihor [1] https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg00410.html In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2020-08-15 built on localhost Repository revision: f712cdbe9e9bdca3d4c7c27e9ac59686ab4c7620 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Gentoo/Linux